Save/Saving switches on the execute bit.

VERIFIED FIXED in M17

Status

()

Core
Editor
P3
trivial
VERIFIED FIXED
19 years ago
17 years ago

People

(Reporter: chimera, Assigned: dougt)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

19 years ago
When saving with the Editor under Build ID 2000011018. The file saved would have
the executable/execute bit turned on. ie instead of the file's permission being
644, they were 755 (with a umask of 022). This would only affect Unix-like
filesystems.

Comment 1

19 years ago
going to shaver for tracking
Assignee: beppe → shaver
(How did shaver@netscape.com get in the bugzilla database again?)

What am I tracking?  I'm lost -- why is this my bug?
Assignee: shaver → shaver

Comment 4

19 years ago
because you were the unix god around here -- will assign it to kin to see what 
can be done
Assignee: shaver → kin

Updated

19 years ago
Target Milestone: --- → M18

Comment 5

19 years ago
Created attachment 8454 [details] [diff] [review]
A patch to fix bug #24052.

Comment 6

19 years ago
About the above patch:
Works in Linux so that default permissions are 655 (or whatever you want them to
be).  The problem was that the wrong nsOuputFileStream constructor was used and
defaulting to 700 in src/mozilla/layout/base/src/nsDocument.cpp.

Comment 7

19 years ago
Created attachment 8478 [details] [diff] [review]
Path that does 644, not 655.

Comment 8

19 years ago
Created attachment 8483 [details] [diff] [review]
This *finally* patches mozilla/layout/base/src/nsDocument.cpp to fix this bug and default the permissions to 644 (and not 700 or 655).

Comment 9

18 years ago
Accepting bug.
Status: NEW → ASSIGNED

Comment 10

18 years ago
asking Kin to review the patch so mozilla folks can approve for checkin
Keywords: patch
Target Milestone: M18 → M17

Comment 11

18 years ago
Created attachment 11660 [details] [diff] [review]
Patch as a one line modification.

Comment 12

18 years ago
Waiting for permission from waterson@mozilla.org or brendan@mozilla.org to check
in the fix.

Comment 13

18 years ago
dougt@netscape.com changed the default permissions to 0666 so the patch is no 
longer neccessary.

    mozilla/xpcom/io/nsFileStream.cpp    revision 1.29
    mozilla/xpcom/io/nsFileStream.h      revision 1.34

a=brendan@mozilla.org
Assignee: kin → dougt
Status: ASSIGNED → NEW

Comment 14

18 years ago
Marking fixed for dougt@netscape.com.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 15

18 years ago
verified in 10/30 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.