240523 - nsIProtocolHandler should document that newURI inherits charset from aBaseURI

Status: RESOLVED INVALID

(Core :: Networking, defect, P5)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

darin said in bug 24867 comment 172:
>> +  var targetURI = IOS.newURI(fileURL.file.leafName, null, targetBaseURI);
>> 
>> you don't need a charset here? it seems you can use
>> contentFrame.document.characterSet...
>
>No need.  The charset is inherited from targetBaseURI.

nsIIOService refers to nsIProtocolHandler for details on newURI, and
nsIProtocolHandler nowhere describes that the charset should be inherited from
the base uri:
http://lxr.mozilla.org/seamonkey/source/netwerk/base/public/nsIProtocolHandler.idl#68

Comment 1

[Andrew Lawson]

I'd be happy to take this one!

Comment 2

[Vyas giridharan]

Can i take this bug?

Comment 3

[Vivek Jain]

Hi
I am a newbie and would like to work on this bug. can somebody assign me to it and help me in the process?

Comment 4

[Patrick McManus [:mcmanus]]

It doesn't need to be assigned - feel free to work on it and upload a patch. :mayhemer would be a good reviewer for the patch.

Comment 5

[Vivek Jain]

Since there is no language tag to it . Can somebody specify the tag as well as tell me where I can find the bits of code to work on

Comment 6

[Vivek Jain]

Since there is no language tag to it . Can somebody specify the tag as well as tell me where I can find the bits of code to work on

Comment 7

[Patrick McManus [:mcmanus]]

comment 0 is just referring to the idl files of the same name

Comment 8

[han]

Is this still a bug? I fetched the code from mozilla-central, and in the nsIProtocolHandler.idl file it says
>> /* if aOriginCharset is null, then UTF-8 encoding is assumed */
>> newURI(... aSpec,
>>        ... aOriginCharset,
>>        ... aBaseUri)

(I shortened most of the documentation)

Comment 9

[mdn]

(In reply to han from comment #8)
> Is this still a bug? I fetched the code from mozilla-central, and in the
> nsIProtocolHandler.idl file it says
> >> /* if aOriginCharset is null, then UTF-8 encoding is assumed */
> >> newURI(... aSpec,
> >>        ... aOriginCharset,
> >>        ... aBaseUri)
> 
> (I shortened most of the documentation)

I think this is counter to the original statement in the bug, which is that the character set would be inherited. This seems to state that, rather than being inherited, UTF-8 is assumed if null is passed. 
A link to the updated idl is https://hg.mozilla.org/mozilla-central/file/tip/netwerk/base/nsIProtocolHandler.idl#l68 . Can this be closed?

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

That is talking about something else... the documentation still does not mention that aBaseURI affects the charset of the resulting URI.

Comment 11

[zy]

Attachment: Git patch file for Bug 240523

Comment 12

[zy]

Attachment: HG patch for bug 240523

Comment 13

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 14

[Ali]

This bug has a patch attached to it for the past 2 months. And the patch seems to provide the correct fix. Why is this ticket still open?

Comment 15

[Ali]

zy, could you hint what is further pending on this ticket? Thanks

Comment 16

[Masatoshi Kimura [:emk]]

After bug 1322874, we do not inherit charset from aBaseURI anymore. We do not even have charset information in URI objects now.

Comment 17

[Honza Bambas (:mayhemer)]

see comment 16.