240550 - Calendar's Background Colors not showing in "Calendar" selection tab

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Justin Wood (:Callek)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113   --(This one works, Bug occurrs in a build pulled on 

Regression:

worked in 1.6, wasnt sure if it was a bug or intended, after talking to
mostafah, told to make bug for it.

Reproducible: Always
Steps to Reproduce:





May be something as simple as a CSS flag?  not fully sure yet.

Comment 1

[Justin Wood (:Callek)]

shoot skipped part of comment, bug occurred on build pulled on:

April 13'th 2004, at 7:00 pm EST

Flags (from mem, filing with 1.6):

--disable-debug  [still occurs with debug]
--enable-svg   ...with gdi+
--enable-calendar
--enable-official-branding  [keep this incase it ever has a use for suite]

and I build in a seperate OBJ-DIR if it makes a diff

also msvc7  (.net)  I didnt build the 1.6

Comment 2

[Justin Wood (:Callek)]

Attachment: Screenshot from 1.6 final

This attachment shows the 'correct' view for it, from 1.6 final

Comment 3

[Justin Wood (:Callek)]

Attachment: Screenshot from current build (1.7+?)

Screenshot of actual result, from current build

Comment 4

[Justin Wood (:Callek)]

Note to self, The RDF file and template list is formed correctly, a testcase
without JS proved such...will work more at a later time on what JS is causing it...

Comment 5

[Justin Wood (:Callek)]

erm ran that testcase in 1.6, think that is a bad testcase, will add in a few.

Comment 6

[Justin Wood (:Callek)]

Talked to Neil and bz about the issue, seems I didnt know that the "style"
attrib was a ToString now, when it was a string before, (meaning the rdf wasnt
parsed before the string was saved as is...and rdf:....is not valid CSS so rule
was being ignored...)

My solution when I get it done is to add the RDF to class (if it works) and
dynamically change it so that I pull it down to the same rule we currently use
for styling the background of events in the actual day/month/week/multiweek views.

If you want to jump on this and fix it for me, go ahead,otherwise it'll be
coming ;-)

Comment 7

[Justin Wood (:Callek)]

Attachment: Proposed Fix

Since we can't parse the rdf: in style tags anymore (in a template), this
appends a class value to the list-items class, that is if there is a color
defined in the RDF.

Comment 8

[Mostafa Hosseini]

Comment on attachment 147939 [details] [diff] [review]
Proposed Fix

r=mostafah

Comment 9

[Mostafa Hosseini]

Checked into CVS.
Thanks for the fix.

Comment 10

[gekacheka]

I'm getting the following error when calendar starts, and no items displayed in
Today's events until I click on a day (even if today has events).

  Error: calListItems[i + 1] has no properties
  Source File: chrome://calendar/content/calendar.js Line 209

Looks like maybe it is trying to access past the end of calListItems?

Moz1.7rc1

Comment 11

[gekacheka]

Attachment: calendar.js patch: check for null calListItem

Patch checks for null calListItem or null calListItem.childNodes[0] before
setting attribute.  Seems to fix the problem for me:  no error in javascript
console, and Today's events now appear when I start calendar.

Comment 12

[Justin Wood (:Callek)]

gecheka, did the list-box/templates change between 1.7's branch and 1.8a?

The reason I added that was because of the fact that calListItem[i] (at first
run) is really in the template itself, (still stored in DOM) and not the ListItem...

Before we have mostafah approve this patch and check in, please verify that your
colors are being applied to the correct calendars in your calendars tab, (which
is the reason I applied "[i+1]"

Thanks, and by the way what OS is your build with, (and FF/TB/Sunbird/Suite ??)

Re-opening too, based on your comment.

Comment 13

[gekacheka]

Actually this is a little mysterious.

Summary:
In Grid:  all show correct color (matches color chosen & shown in edit dialog)
          except eleventh, which always shows gray no matter color chosen.
In List:  First six: ok.
          Seventh and tenth:  show white
          Eleventh and twelfth:  show gray
          Thirteenth: shows color of twelfth

Details:

The first six calendars are are listed with their colors.
The seventh calendar is listed with no color (white), though its color does
appear in the edit dialog button and on the tasks, so it does have a color.
The eighth and ninth calendars are listed with their colors.
The tenth calendar is like the seventh, no color (white), though it does have a
color.
The eleventh calendar shows gray in both the calendar list and the events in the
grid, even if I set it to another color and the edit dialog button shows the set
color.
The twelfth calendar shows gray in the calendar list, but the correct color in
the grid.  Changing the color of the twelfth calendar in the calendar list
changes the color of the thirteeth calendar name in the list, not the twelfth,
but does change the color of the events of the twelfth calendar in the grid.
The thirteenth calendar shows the color of the twelfth calendar in the calendar
list, but events show the correct color in the grid.

Comment 14

[Justin Wood (:Callek)]

hmm odd.

gekacheka, can you comment with the "class" names for each (and every) set of
items that my patch had set the class on, in your tree, (use the DOM Inspector).
 and withyour patch probably also.

And it could help if you attach your:

@profile-dir@/calendar/CalendarManager.rdf

if you do not mind, would help figure this out.

Comment 15

[gekacheka]

As requested, DOM Inspector of calendars list, and rdf:

listbox	       list-calendars-listbox	unifinder-tree-class
 listcols
 xul:listrows
  listhead
  xul:listbody
   listitem    urn:calendarcontainer:calendar0	
    listcell				calendar-list-item-class calendar0
    listcell
   listitem    urn:calendarcontainer:calendar1
    listcell				calendar-list-item-class calendar1
    listcell
   listitem    urn:calendarcontainer:calendar2
    listcell				calendar-list-item-class calendar2
    listcell
   listitem    urn:calendarcontainer:calendar3
    listcell				calendar-list-item-class calendar3
    listcell
   listitem    urn:calendarcontainer:calendar4
    listcell				calendar-list-item-class calendar4
    listcell
   listitem    urn:calendarcontainer:calendar5
    listcell				calendar-list-item-class calendar5
    listcell
   listitem    urn:calendarcontainer:calendar6
    listcell				calendar-list-item-class
    listcell
   listitem    urn:calendarcontainer:calendar8
    listcell				calendar-list-item-class calendar8
    listcell
   listitem    urn:calendarcontainer:calendar9
    listcell				calendar-list-item-class calendar9
    listcell
   listitem    urn:calendarcontainer:calendar10
    listcell				calendar-list-item-class
    listcell
   listitem    urn:calendarcontainer:calendar11
    listcell				calendar-list-item-class calendar11
    listcell
   listitem    urn:calendarcontainer:calendar12
    listcell				calendar-list-item-class calendar11
    listcell
   listitem    urn:calendarcontainer:calendar1059675953077
    listcell				calendar-list-item-class calendar12
    listcell


<?xml version="1.0"?>
<RDF:RDF xmlns:JSLIB="http://jslib.mozdev.org/rdf#"
         xmlns:NC="http://home.netscape.com/NC-rdf#"
         xmlns:RDF="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
  <RDF:Description RDF:about="urn:calendarcontainer:calendar8"
                   NC:serverNumber="9"
                   NC:path="@profile@\Calendar\USMAStateHolidays.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:active="true"
                   NC:name="US MA State Holidays"
                   NC:publishAutomatically="false"
                   NC:color="#FFCC99" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar1"
                   NC:serverNumber="2"
                   NC:path="@profile@\Calendar\USFederalHolidays.ics"
                   NC:remote="true"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:name="US Federal Holidays"
                   NC:publishAutomatically="false"
                   NC:color="#9999FF"
                   NC:active="false" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar9"
                   NC:serverNumber="10"
                   NC:path="@profile@\Calendar\USMAStateObservances.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:name="US MA State Observances"
                   NC:publishAutomatically="false"
                   NC:color="#FFCC99"
                   NC:active="true" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar1059675953077"
                   NC:serverNumber="14"
                   NC:path="@profile@\Calendar\CalendarDataFile14.ics"
                   NC:remote="false"
                   NC:username=""
                   NC:password=""
                   NC:remotePath=""
                   NC:name="@thirteenth@"
                   NC:publishAutomatically="false"
                   NC:active="true">
    <NC:color>#CCFFFF</NC:color>
    <NC:color>#99FF99</NC:color>
  </RDF:Description>
  <RDF:Seq RDF:about="urn:calendarcontainer">
    <RDF:li RDF:resource="urn:calendarcontainer:calendar0"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar1"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar2"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar3"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar4"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar5"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar6"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar8"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar9"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar10"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar11"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar11"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar12"/>
    <RDF:li RDF:resource="urn:calendarcontainer:calendar1059675953077"/>
  </RDF:Seq>
  <RDF:Description RDF:about="urn:calendarcontainer:calendar12"
                   NC:serverNumber="13"
                   NC:path="@profile@\Calendar\CalendarDataFile13.ics"
                   NC:remote="false"
                   NC:active="false"
                   NC:username=""
                   NC:password=""
                   NC:remotePath=""
                   NC:name="@twelfth@"
                   NC:publishAutomatically="false"
                   NC:color="#FF6666" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar4"
                   NC:serverNumber="5"
                   NC:path="@profile@\Calendar\JPNationalHolidays_en.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:active="true"
                   NC:name="JP National Holidays"
                   NC:publishAutomatically="false"
                   NC:color="#FFCCCC" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar6"
                   NC:serverNumber="7"
                   NC:path="@profile@\Calendar\RemoteCalendar7.ics"
                   NC:remote="true"
                   NC:username=""
                   NC:password=""
                   NC:name="CAnada Holidays"
                   NC:remotePath="http://zillavilla.com/CanadaHolidays.ics"
                   NC:publishAutomatically="false"
                   NC:color="#CCCCFF"
                   NC:active="true" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar3"
                   NC:serverNumber="4"
                   NC:path="@profile@\Calendar\USFederalObservances.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:name="US Federal Observances"
                   NC:publishAutomatically="false"
                   NC:color="#CCCCFF"
                   NC:active="false" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar2"
                   NC:serverNumber="3"
                   NC:path="@profile@\Calendar\USPopularObservances.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:name="US Popular Observances"
                   NC:publishAutomatically="false"
                   NC:color="#CCFFFF"
                   NC:active="false" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar5"
                   NC:serverNumber="6"
                   NC:path="@profile@\Calendar\JPPopularObservances_en.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:name="JP Popular Observances"
                   NC:publishAutomatically="false"
                   NC:color="#FFCCCC"
                   NC:active="true" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar10"
                   NC:serverNumber="11"
                   NC:name="US CA State Holidays"
                   NC:path="@profile@\Calendar\USCAStateHolidays.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:active="true" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar0"
                   NC:path="@profile@\Calendar\CalendarDataFile.ics"
                   NC:remote="false"
                   NC:remotePath=""
                   NC:username=""
                   NC:password=""
                   NC:name="My Calendar"
                   NC:publishAutomatically="false"
                   NC:color="#FFFFFF"
                   NC:active="true" />
  <RDF:Description RDF:about="urn:calendarcontainer:calendar11"
                   NC:serverNumber="12"
                   NC:path="@profile@\Calendar\CalendarDataFile12.ics"
                   NC:remote="false"
                   NC:username=""
                   NC:password=""
                   NC:remotePath=""
                   NC:active="true"
                   NC:name="@eleventh@"
                   NC:publishAutomatically="false"
                   NC:color="#99FF99" />
</RDF:RDF>

Comment 16

[Justin Wood (:Callek)]

hmm, do you happen to have any M's on a tree-pull that /could/ affect this,
seems also that there may be a few ambiguities in your RDF file, though can't be
sure...probably need to direct mostafah's expertise on this

Comment 17

[gekacheka]

In case my CalendarManager.rdf file has become corrupted over the years, is
there any easy way to rebuild it?  Looks like there's no way to simply delete
and readd local calendar files.

Comment 18

[Mostafa Hosseini]

Comment on attachment 148588 [details] [diff] [review]
calendar.js patch: check for null calListItem

Patch checked in.thanks.
Can this be closed now?

Comment 19

[Justin Wood (:Callek)]

gekecheka, I'm marking resolved, re-file a bug on your incorrect colors, we can
still look into that, point to these comments for that.

Comment 20

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!