Closed Bug 240562 Opened 20 years ago Closed 20 years ago

In <nsStyleStruct.cpp>, [Unused variable `nsIFrame*parentFrame']

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.8alpha1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 obsolete file)

From "Blamed Build Warnings / Linux brad Clobber":
{{
roc+

1.	content/shared/src/nsStyleStruct.cpp:74 (See build log excerpt)
	Unused variable `nsIFrame*parentFrame'

72 {
73   nscoord result = 0;
74   nsIFrame* parentFrame = aFrame->GetParent();
75 
76   switch (aCoord.GetUnit()) {
}}
*** Bug 240563 has been marked as a duplicate of this bug. ***
Blocks: 228780
No longer blocks: 126457
Removing line 74:
{{
  74 roc+     3.54   nsIFrame* parentFrame = aFrame->GetParent();

  84 roc+     3.54	   nsIFrame* frame = aFrame->GetParent();
}}
Line 84 should be enough :->
Assignee: nobody → gautheri
Status: NEW → ASSIGNED
Comment on attachment 146151 [details] [diff] [review]
(Av1) <nsStyleStruct.cpp>
[Checked in: Comment 5]


I have no compiler: Could you compile/test/review this patch ? Thanks.
Attachment #146151 - Flags: review?(daniel)
Comment on attachment 146151 [details] [diff] [review]
(Av1) <nsStyleStruct.cpp>
[Checked in: Comment 5]

Absolutely!
r=daniel@glazman.org
Attachment #146151 - Flags: review?(daniel) → review+
Attachment #146151 - Flags: superreview?(roc)
Attachment #146151 - Flags: superreview?(roc) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #146151 - Attachment description: (Av1) <nsStyleStruct.cpp> → (Av1) <nsStyleStruct.cpp> [Checked in: Comment 5]
Attachment #146151 - Attachment is obsolete: true
Target Milestone: --- → mozilla1.8alpha
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: