240572 - Consider hashing results of getElementsByAttribute

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P5)

Description

[Boris Zbarsky [:bzbarsky]]

Now that getElementsByAttribute returns a content list, we could hash the return
values like we do for getElementsByTagName.  This would require that we push
more members up to nsContentListKey, though (and maybe make the key generation
more complicated).

Thoughts?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

my thoughts: I wouldn't stress out about it. If it shows up in profiles we could
reconsider.

As brendan said in some other bug: premature optimizations is the root of all evil. 

Comment 2

[Johnny Stenback (:jst)]

Agreed re premature optimizations in general, but if an optimization is obvious
and trivial, I see little reason not to do it, as seems to be the case here.

I.e. add two more members to the nsContentListKey, and update the hash
generation and key comparison methods to take those into account. No extra bloat
(since the members are already there, they'd just be moved), just a tiny bit of
new code, and very little extra cost for the old cases and a good optimization
for the new cases.

I say it wouldn't be a waste of time to do this.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 4

[Anne (:annevk)]

No stress had and no time (not) wasted.