240845 - Clarify on the login page that login is an email address.

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Keith Bissett]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

At login, the page does not make it clear that the login required is an email
address.  Bugzilla is also the sort of site that people will tend to use
infrequently.  Since people have various logins for various sites, it would be a
handy to jog the memory as to what is required.

You could probably even just call the field something like "Registered email
address".

Reproducible: Always
Steps to Reproduce:

Comment 1

[Dave Miller [:justdave]]

But it isn't necessarily an email address.  On most bugzilla sites it is, but it
doesn't have to be.  That statement was intentionally removed because some sites
don't use an email address as the login ID...

Comment 2

[Dave Miller [:justdave]]

Not sure if we want this (see comment 1) but it seems to be applied to b.m.o
already, so attaching the patch for posterity.

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch

Comment 4

[Sunil Joshi [:sjoshi]]

Comment on attachment 168488 [details] [diff] [review]
Patch

Just adding a reviewer.

Comment 5

[Frédéric Buclin]

Comment on attachment 168488 [details] [diff] [review]
Patch

No, as said in comment 1, login != email address.

Comment 6

[Sunil Joshi [:sjoshi]]

Well in that case , this stands Invalid for me.

Comment 7

[Frédéric Buclin]

(In reply to Sunil Joshi from comment #6)
> Well in that case , this stands Invalid for me.

Depends on the value of the emailsuffix parameter. If it's empty, then login == email address.

Comment 8

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v2

Oops !! Yes agree.

Comment 9

[Frédéric Buclin]

Comment on attachment 782186 [details] [diff] [review]
Patch-v2

That's exactly the opposite. If emailsuffix is in use, then you must *not* enter your email address. Also, please fix the indentation:

<tr>
  <th>
    <label>
    </label>
  </th>
  ...

Comment 10

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v3

Comment 11

[Simon Green]

Comment on attachment 782189 [details] [diff] [review]
Patch-v3

Review of attachment 782189 [details] [diff] [review]:
-----------------------------------------------------------------

Indentation is still incorrect. It should be two spaces for each level (including TT lines).

Comment 12

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v4

With review comments.

Comment 13

[Simon Green]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/account/auth/login.html.tmpl
Committed revision 8686.

Unfortunately, the commit log will forever refer to bug 899679. Very sorry about that.