240907 - build failed making ../../dist/bin/defaults/pref/composer.js because ../../dist/bin/defaults does not exist

Status: RESOLVED INVALID

(SeaMonkey :: Build Config, defect)

Description

[timeless]

i decided to blow away my gtk tree and build from scratch.

i believe my build failed a few times, so i might have helped it along a bit.

i came back a few days later and saw that my build failed:

mozhack@boffo:~/obj-i686-pc-linux-gnu-gtk/editor/ui$ make
/usr/bin/gmake export
gmake[1]: Entering directory `/mnt/ibm/mozhack/obj-i686-pc-linux-gnu-gtk/editor/ui'
set -e;   \
for i in /mnt/ibm/mozhack/mozilla/editor/ui/composer.js; \
do /usr/bin/perl /mnt/ibm/mozhack/mozilla/config/preprocessor.pl 
-DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DMOZILLA_VERSION=\"1.7b\"
-DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1
-DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1
-DHAVE_UNAME_US_DOMAINNAME_FIELD=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1
-DHAVE_SYS_BITYPES_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_GNU_LIBC_VERSION_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1
-DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_CDEFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DFUNCPROTO=15 -DHAVE_XSHM=1
-D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_NL_LANGINFO=1
-DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_RES_NINIT=1
-DHAVE_GNU_GET_LIBC_VERSION=1 -DVA_COPY=__va_copy -DHAVE_VA_COPY=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DMOZ_WIDGET_GTK=1
-DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_APP_NAME=\"mozilla\"
-DMOZ_ENABLE_COREXFONTS=1 -DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1 -DIBMBIDI=1
-DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1
-DMOZ_MATHML=1 -DMOZ_LOGGING=1 -DHAVE___BUILTIN_VEC_NEW=1
-DHAVE___BUILTIN_VEC_DELETE=1 -DHAVE___BUILTIN_NEW=1 -DHAVE___BUILTIN_DELETE=1
-DHAVE___PURE_VIRTUAL=1 -DMOZ_ENABLE_OLD_ABI_COMPAT_WRAPPERS=1
-DMOZ_USER_DIR=\".mozilla\" -DINCLUDE_AURAL=1 -DMOZ_XUL=1 -DMOZ_PROFILESHARING=1
-DMOZ_PROFILELOCKING=1 -DSUNCTL=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1
-DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1
-DMOZILLA_LOCALE_VERSION=\"1.7b\" -DMOZILLA_REGION_VERSION=\"1.7b\"
-DMOZILLA_SKIN_VERSION=\"1.5\"  $i > ../../dist/bin/defaults/pref/`basename $i`; \
done
/bin/sh: ../../dist/bin/defaults/pref/composer.js: No such file or directory
gmake[1]: *** [export] Error 1
gmake[1]: Leaving directory `/mnt/ibm/mozhack/obj-i686-pc-linux-gnu-gtk/editor/ui'
make: *** [all] Error 2
mozhack@boffo:~/obj-i686-pc-linux-gnu-gtk/editor/ui$ ls ../../dist/bin/defaults
/bin/ls: ../../dist/bin/defaults: No such file or directory

The directory doesn't exist, so the rule to make the file fails because it can't
write the file into a directory that doesn't exist. I think the rule should
probably create the directory ...

Comment 1

[cls]

There's already a rule to create the directory if it doesn't exist:
http://lxr.mozilla.org/seamonkey/source/config/rules.mk#1236 .  When I remove
dist/bin and (cd editor/ui && make), everything builds fine.  You don't have a
dist/ dir in the source tree or anything screwy like that, do you?

Comment 2

[timeless]

that'd do it.

think we could have a file that means "this source tree wants to be only used
with objdirs"? the problem is if i accidentally start a build and my mozconfig
env var isn't set, the world corrupts itself. 

i suppose i could construct a mozilla/.mozconfig file which intentionally dies.
mk_add_options MOZ_OBJDIR=/dev/null

works.

Comment 3

[cls]

Yeah, I have something similar in my default mozconfig.  I'm all for disabling
srcdir builds all together.  We may want to add dist/ to the srcdir check that
we currently have in place in configure.in.