Closed Bug 240929 Opened 20 years ago Closed 20 years ago

make dialogs modal

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

Details

Attachments

(3 files)

patch
13.06 KB, patch
dveditz
: review+
Details | Diff | Splinter Review
patch merged to trunk
13.00 KB, patch
bryner
: superreview+
Details | Diff | Splinter Review
patch to play nicely with bug 236294
12.30 KB, patch
Details | Diff | Splinter Review 
The installer has various dialogs that require user input before the installer
can procede, but the main installer window is still active, so the user can try
to do other stuff (hit next, change dir, etc).  It's evil, but they do it.  In
some places, the installer tries to protect against this, but in most places it
doesn't.

These dialogs should just be modal, so the user can't do anything but deal with
the dialog before moving on.
Attached patch patch — — Splinter Review 

    
  

        Attachment #146462 -
        Flags: review?(dveditz)

    
    

    
  
Comment on attachment 146462 [details] [diff] [review]
patch

r=dveditz

        Attachment #146462 -
        Flags: review?(dveditz) → review+

    
    

    
  


  

    
  

        Attachment #147006 -
        Flags: superreview?(bryner)

    
    

    
  
Comment on attachment 147006 [details] [diff] [review]
patch merged to trunk

Yep.  I did some of this for the firefox gtk2 installer.  The only possible
reasons I could come up with for the old behavior is that old gtk versions
didn't support the modality hints, or that window managers didn't realiably
support them.  In either case, I think they're well-supported now.

        Attachment #147006 -
        Flags: superreview?(bryner) → superreview+

    
    

    
  


  
this just doesn't include the changes to ShowCRCFailedDlg, which is getting
removed by bug 236294

    
    

    
  
checked in by timeless
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: