--disable-profilelocking option does not work

RESOLVED FIXED

Status

RESOLVED FIXED
15 years ago
2 years ago

People

(Reporter: wind.li, Assigned: wind.li)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

nsProfile.cpp ignore this option

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 1

15 years ago
Created attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

if --disable-profilelocking  is not setted then
will not be defined MOZ_PROFILELOCKING
(Assignee)

Updated

15 years ago
Attachment #146479 - Flags: review?(brendan)
(Assignee)

Comment 2

15 years ago
I am working for OOo, we use Mozilla components to access addressbooks in OOo in
nearly readonly mode.
See http://dba.openoffice.org and
http://qa.openoffice.org/issues/show_bug.cgi?id=11424 for detail.
So we need build a Mozilla without profile locking function. I found that there
is a config option --disable-profilelocking. But it does not work. So I make
this patch.
Blocks: 213274
Comment on attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

I'm not a module owner or peer for profile.  Wind, please follow the rules in
http://www.mozilla.org/hacking/.

/be
Attachment #146479 - Flags: review?(brendan) → review?(ccarlen)

Comment 4

15 years ago
Comment on attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

+ #endif
 ^ errant whitespace
Assignee: nobody → wind.li
Component: Build Config → Profile Manager BackEnd
QA Contact: core.build-config → core.profile-manager-backend
(Assignee)

Comment 5

15 years ago
Created attachment 146482 [details] [diff] [review]
remove the space

:)
Attachment #146479 - Attachment is obsolete: true
Comment on attachment 146482 [details] [diff] [review]
remove the space

r=ccarlen.

I think somebody added --disable-profilelocking to support only the
--enable-single-profile config (where there is no profile mgr) for minimo. This
makes it work in any case.
Attachment #146482 - Flags: review+
(Assignee)

Comment 7

15 years ago
ccarlen
Can you please suggest a superreviewer?
Thanks
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

15 years ago
Attachment #146482 - Flags: superreview+
Comment on attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

removing obsolete review req.
Attachment #146479 - Flags: review?(ccarlen)

Comment 9

15 years ago
fixed.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.