nsXPComInit.cpp has wrong offset checking for post 1.6 functions

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Marco Pesenti Gritti, Assigned: dougt)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
853 bytes, patch
Darin Fisher
: review+
Darin Fisher
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
It checks for cstringCopy which isnt the latest 1.7 function in the structure
(utf16ToCString). I guess someone forgot to update it when the conversion
functions was added.
(Reporter)

Comment 1

13 years ago
Created attachment 146530 [details] [diff] [review]
fix
(Reporter)

Updated

13 years ago
Attachment #146530 - Flags: review?(darin)

Comment 2

13 years ago
Comment on attachment 146530 [details] [diff] [review]
fix

r+sr=darin
Attachment #146530 - Flags: superreview+
Attachment #146530 - Flags: review?(darin)
Attachment #146530 - Flags: review+
(Reporter)

Updated

13 years ago
Attachment #146530 - Flags: approval1.7?

Comment 3

13 years ago
fixed-on-trunk for 1.8 alpha
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Reporter)

Updated

13 years ago
Attachment #146530 - Flags: approval1.7?
You need to log in before you can comment on or make changes to this bug.