Closed Bug 241147 Opened 20 years ago Closed 20 years ago

DecodeStructParticle fails on 'sequences' and 'choices'

Categories

(Core Graveyard :: Web Services, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7final

People

(Reporter: darin.moz, Assigned: darin.moz)

Details

(Keywords: fixed1.7)

Attachments

(1 file)

DecodeStructParticle fails on 'sequences' and 'choices'

This prevents writing a webservice that returns a struct type.

The patch is a one-line update-the-iterator fix! :-/
Attached patch v1 patchSplinter Review
Attachment #146641 - Flags: superreview?(jst)
Attachment #146641 - Flags: review?(bugs)
This is blocking the Firefox 0.9 extension manager.
Status: NEW → ASSIGNED
Flags: blocking1.7?
Priority: -- → P1
Target Milestone: --- → mozilla1.7final
Comment on attachment 146641 [details] [diff] [review]
v1 patch

-	     rc = DecodeStructParticle(aEncoding, aElement, child,
aAttachments, aDestination, getter_AddRefs(after));
+	     rc = DecodeStructParticle(aEncoding, next, child, aAttachments,
aDestination, getter_AddRefs(after));

Nice :)

	     if (!NS_FAILED(rc)) {

Wanna change that to NS_SUCCEEDED(rc) while you're here (there's more than one
tho...)?

sr=jst
Attachment #146641 - Flags: superreview?(jst) → superreview+
i'll cleanup the "!NS_FAILED" junk in another patch... i want to keep this one
simple since it needs to land for 1.7 as well.
Attachment #146641 - Flags: approval1.7?
fixed-on-trunk for 1.8 alpha
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 146641 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #146641 - Flags: approval1.7? → approval1.7+
fixed1.7
Keywords: fixed1.7
Flags: blocking1.7?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: