Closed
Bug 241147
Opened 21 years ago
Closed 21 years ago
DecodeStructParticle fails on 'sequences' and 'choices'
Categories
(Core Graveyard :: Web Services, defect, P1)
Core Graveyard
Web Services
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7final
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
(Keywords: fixed1.7)
Attachments
(1 file)
|
1.39 KB,
patch
|
bugs
:
review+
jst
:
superreview+
asa
:
approval1.7+
|
Details | Diff | Splinter Review |
DecodeStructParticle fails on 'sequences' and 'choices' This prevents writing a webservice that returns a struct type. The patch is a one-line update-the-iterator fix! :-/
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #146641 -
Flags: superreview?(jst)
Attachment #146641 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•21 years ago
|
||
This is blocking the Firefox 0.9 extension manager.
Status: NEW → ASSIGNED
Flags: blocking1.7?
Priority: -- → P1
Target Milestone: --- → mozilla1.7final
|
||
Comment 3•21 years ago
|
||
Comment on attachment 146641 [details] [diff] [review] v1 patch r=ben@mozilla.org
Attachment #146641 -
Flags: review?(bugs) → review+
|
||
Comment 4•21 years ago
|
||
Comment on attachment 146641 [details] [diff] [review] v1 patch - rc = DecodeStructParticle(aEncoding, aElement, child, aAttachments, aDestination, getter_AddRefs(after)); + rc = DecodeStructParticle(aEncoding, next, child, aAttachments, aDestination, getter_AddRefs(after)); Nice :) if (!NS_FAILED(rc)) { Wanna change that to NS_SUCCEEDED(rc) while you're here (there's more than one tho...)? sr=jst
Attachment #146641 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
i'll cleanup the "!NS_FAILED" junk in another patch... i want to keep this one simple since it needs to land for 1.7 as well.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #146641 -
Flags: approval1.7?
|
|
Assignee | |
Comment 6•21 years ago
|
||
fixed-on-trunk for 1.8 alpha
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Comment 7•21 years ago
|
||
Comment on attachment 146641 [details] [diff] [review] v1 patch a=asa (on behalf of drivers) for checkin to 1.7
Attachment #146641 -
Flags: approval1.7? → approval1.7+
|
|
||
Updated•21 years ago
|
Flags: blocking1.7?
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•