Clean up some webservices code

RESOLVED FIXED

Status

Core Graveyard
Web Services
RESOLVED FIXED
14 years ago
a month ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

14 years ago
 
(Assignee)

Comment 1

14 years ago
Created attachment 146681 [details] [diff] [review]
v1

Remove space after NS_IMETHODIMP, switch to nsCOMArray instead of
nsSupportsArray and nsInterfaceHashtable instead of nsSupportsHashtable, use
nsAutoPtr for mArrayInfo, use better string foo, correct anyUri to anyURI (see
http://www.w3.org/TR/2001/REC-xmlschema-2-20010502/#anyURI).
(Assignee)

Comment 2

14 years ago
Created attachment 146682 [details] [diff] [review]
v1 (diff -w)
(Assignee)

Updated

14 years ago
Attachment #146681 - Flags: superreview?(jst)
Attachment #146681 - Flags: review?(jst)
Comment on attachment 146681 [details] [diff] [review]
v1

Very nice! r+sr=jst
Attachment #146681 - Flags: superreview?(jst)
Attachment #146681 - Flags: superreview+
Attachment #146681 - Flags: review?(jst)
Attachment #146681 - Flags: review+
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Erm. This patch causes the app to crash in my extension manager (not enabled
completely yet, but a use of SOAP)...

###!!! ASSERTION: nsTHashtable was not initialized properly.: 'mTable.entrySize'
, file ../../../../dist/include/xpcom\nsTHashtable.h, line 179

DecodeStructParticle (when returning complex types) calls nsSchema::AddType
which attempts to do a hash operation and fails with the following assertion
followed by a crash. 

This is blocking my 0.9 extension manager work. We need a good test suite for
web services so this sort of stuff doesn't keep breaking.
(Assignee)

Comment 5

14 years ago
Created attachment 146969 [details] [diff] [review]
Bustage fix

I seem to have missed some code to init the hashtables. I just checked in this
patch, it should fix that crash.
Thanks for the fast turnaround!

Comment 7

13 years ago
Created attachment 164003 [details] [diff] [review]
Patch for AVIARY

Modifications seem not to have been applied before aviary

Updated

13 years ago
Attachment #164003 - Flags: review?(keeda)

Comment 8

13 years ago
Comment on attachment 164003 [details] [diff] [review]
Patch for AVIARY

At this stage you won't get aviary approval of anything other than small and
clear bugfixes. It is much too late for random cleanup.
Attachment #164003 - Flags: review?(keeda) → review-

Comment 9

13 years ago
(In reply to comment #8)
> (From update of attachment 164003 [details] [diff] [review])
> At this stage you won't get aviary approval of anything other than small and
> clear bugfixes. It is much too late for random cleanup.
> 

So is there any devel sub-branch for aviary one on which I could try to apply
this patch and on which I could get approval for ?

Updated

13 years ago
Attachment #164003 - Attachment is obsolete: true

Updated

a month ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.