Closed
Bug 241206
Opened 21 years ago
Closed 3 years ago
nsIFilePicker.displayDirectory should not share its directory with consumers
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 268311
People
(Reporter: timeless, Unassigned)
Details
Attachments
(1 file)
|
15.21 KB,
patch
|
emaijala+moz
:
review-
|
Details | Diff | Splinter Review |
The current ownership model means that if you do:
fp.displayDirectory=path;
path.initWithDirectory(...);
the filepicker's display directory changes. IMO that's wrong.
The code also has a tendency to crash if you assign null...
Attachment #146685 -
Flags: superreview?(rbs)
Attachment #146685 -
Flags: review?(ere)
|
||
Comment 2•21 years ago
|
||
+ mDisplayDirectory = do_CreateInstance("@mozilla.org/file/local;1");
there's this Clone method on nsIFile...
|
||
Comment 3•21 years ago
|
||
Comment on attachment 146685 [details] [diff] [review]
per description (-uwp6)
I don't know nsIFile well, but I trust Biesi that Clone would do the trick in a
cleaner way.
Attachment #146685 -
Flags: superreview?(rbs)
Attachment #146685 -
Flags: review?(ere)
Attachment #146685 -
Flags: review-
|
||
Comment 5•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:enndeakin, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee: timeless → nobody
Flags: needinfo?(enndeakin)
|
||
Comment 6•3 years ago
|
||
Looks like he already fixed this in a different bug.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(enndeakin)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•