Closed
Bug 241262
Opened 20 years ago
Closed 7 years ago
npapi's [u]int32 isn't guaranteed to always be 32 bits.
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: jst, Assigned: peterlubczynski-bugs)
Details
Attachments
(1 file)
|
772 bytes,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
http://lxr.mozilla.org/mozilla/source/modules/plugin/base/public/npapi.h#188 188 #ifndef _UINT32 189 # if defined(__alpha) 190 typedef unsigned int uint32; 191 # else /* __alpha */ 192 typedef unsigned long uint32; 193 # endif /* __alpha */ 194 #endif _UINT32 is defined for non-mac platforms in this file, so I don't know what good this really does us, but it seems wrong to assume that "long" is 32-bits on non-alpha mac platforms :-) This should be cleaned up at some point.
|
||
Comment 1•16 years ago
|
||
|
Reporter | |
Updated•16 years ago
|
Attachment #324023 -
Flags: superreview+
Attachment #324023 -
Flags: review+
|
|
Reporter | |
Comment 2•16 years ago
|
||
This can be checked in, but the bug should remain open I think, there's probably more to do here...
Keywords: checkin-needed
|
||
Comment 3•16 years ago
|
||
http://hg.mozilla.org/index.cgi/mozilla-central/rev/05d95de6cbc5
Keywords: checkin-needed
|
|
||
Updated•16 years ago
|
Attachment #324023 -
Attachment description: got caught with this recently → got caught with this recently (checked in)
|
||
Updated•15 years ago
|
QA Contact: plugins
|
||
Comment 4•7 years ago
|
||
I believe we're using c99 uint32_t types now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•