Closed Bug 241337 Opened 20 years ago Closed 20 years ago

Make nsWebScriptsAccess::IsPublicService deal better with errors

Categories

(Core Graveyard :: Web Services, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: keeda, Assigned: keeda)

Details

(Keywords: fixed-aviary1.0, fixed1.7.5)

Attachments

(1 file)

nsWebScriptsAccess::IsPublicService() looks for a hidden pref and returns an
error value if it is not found. This error gets propogated back to the user and
masks the real error handling in layers above. Not finding this pref really
shouldn't be an error, just making sure that you dont flag the service as public
should be enough. 

I am pulling this out of a two month old tree and I cant recollect the specific
details of what I was doing, and the exact errors that were getting reported.
But this made the JSConsole report something like "service not accessible" which
is far better than the generic failure message that I was getting earlier.
Attached patch FixSplinter Review
Attachment #146786 - Flags: review?(jst)
Comment on attachment 146786 [details] [diff] [review]
Fix

r+sr=jst
Attachment #146786 - Flags: superreview+
Attachment #146786 - Flags: review?(jst)
Attachment #146786 - Flags: review+
Checked in. 
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
this is breaking some stuff, asking for 1.7.2/aviary 
Flags: blocking1.7.2?
Flags: blocking-aviary1.0RC1?
Comment on attachment 146786 [details] [diff] [review]
Fix

a=mkaply for 1.7.2
Attachment #146786 - Flags: approval1.7.2+
If this landed on the 1.7 branch then we need to get it for Aviary too.
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
ben actually checked this in already.
Keywords: fixed-aviary1.0
Keywords: fixed1.7.5
Flags: blocking1.7.5?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: