Generate OS/2 icon as part of build

RESOLVED WONTFIX

Status

SeaMonkey
Build Config
RESOLVED WONTFIX
14 years ago
13 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Currently we place an OS/2 icon in the build.

It would be much more interesting if we generated it.

this would get us updates automatically.

We've already added a prereq for the new tool in our build docs.
(Assignee)

Comment 1

14 years ago
Created attachment 146809 [details] [diff] [review]
Patch

rule for ICOFILE and conversion in rules.mk

New name is iconname-os2.ico
you don't want this for the icons in xpfe/bootstrap/icons/?

Comment 3

14 years ago
Comment on attachment 146809 [details] [diff] [review]
Patch

>Index: rules.mk

>+OS2ICOFILE := $(patsubst %.ico, %-os2.ico, $(ICOFILE))

Use = instead of := unless there is a reason you need immediate evaluation.
Attachment #146809 - Flags: review+
(Assignee)

Comment 4

14 years ago
biesi:

The main problem I am trying to solve here is icons bound directly to the
executable.

My plan in the very near future is to allow the OS/2 build to load Windows icons
directly.
And what about the Firefox and Thunderbird icons?
(Assignee)

Comment 6

14 years ago
NEver mind

The tool we have doesn't convert the thunderbird and firefox icons correctly
without manipulation.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.