241487 - duetoday not working

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Steve Hampton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040418 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040418 Firefox/0.8.0+

On the task list, a task that is due today (set aside with blue text) shows to
be overdue (red text) unless the task is due today at 11:59 pm.

 

Reproducible: Always
Steps to Reproduce:
1. create task with today's date. text is red
2. change time due to 11:59 p.m., text changes to blue
3.

Actual Results:  
text was red

Expected Results:  
should be blue.

In unifinderToDo.js, line 259 is:

if( tonightMidnight.getTime() > dueDate.getTime() )

it should be

if( thisMorning.getTime() > dueDate.getTime() )

Comment 1

[Eric Belhaire]

Attachment: patch as described above. Worksforme with this workaround

Comment 2

[Eric Belhaire]

Comment on attachment 147232 [details] [diff] [review]
patch as described above. Worksforme with this workaround

>--- new/content/calendar/unifinderToDo.js	2004-04-28 16:46:16.000000000 +0200
>+++ orig/content/calendar/unifinderToDo.js	2004-04-07 00:53:20.000000000 +0200
>@@ -254,13 +254,13 @@
>       }
>       
>       var startDate     = new Date( calendarToDo.start.getTime() );
>       var dueDate       = new Date( calendarToDo.due.getTime() );
>       var tonightMidnight = new Date( now.getFullYear(), now.getMonth(), now.getDate(), 23, 59, 00 );
>       
>-      if( thisMorning.getTime() > dueDate.getTime() )
>+      if( tonightMidnight.getTime() > dueDate.getTime() )
>       {
>          return("overdue");
>       } else 
> 	if ( dueDate.getFullYear() == now.getFullYear() &&
>                   dueDate.getMonth() == now.getMonth() &&
>                   dueDate.getDate() == now.getDate() )

Comment 3

[Mostafa Hosseini]

Comment on attachment 147232 [details] [diff] [review]
patch as described above. Worksforme with this workaround

Reverse of patch checked in.

Comment 4

[Mostafa Hosseini]

Fixed in CVS.

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!