241506 - onStatusChange in nsProgressDialog should do nothing

Status: RESOLVED INVALID

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

so, as it is, this shows an error dialog when aStatus is not a success code.
But, when this is called, the notifications are coming from webbrowserpersist,
which gets them through nsIProgressEventSink::OnStatus.

now, a real error will not be notified this way. in fact, that's handled
elsewhere already.

this code should just be not there.

but, it also exists in nsProgressDialog; and firefox of course duplicated this
code into two (!?) helper app dialog impls

Comment 1

[Boris Zbarsky [:bzbarsky]]

So a problem is that nsIWebProgressListener claims a nsresult status; should it
really claim some other type?

If not, it should very clearly document what that status means.

I guess we should file some bugs on firefox too.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

nevermind, this is also called from nsExternalAppHandler::SendStatusChange, and
it is very definitely an error there.