241773 - Broken Animated GIF displays partially then may cause crash

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Ben Isaacs]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040425 Firefox/0.8.0+

Certain animated GIFs, particularly the one in the provided URL, "don't play" 
in Mozilla or Firefox. That particular URL has been used as a "Firefox 
crasher" on a message board I admin, because in Firefox 0.8 (Mozilla/5.0 
(Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8) this 
image actually causes Firefox to CRASH.

In the latest nightly build, and in Mozilla 1.7b, it does not cause a crash 
but it still fails to render. 

If you save the image to your hard disk and then try to open the image, it 
displays a "this image contains errors" box. In Firefox 0.8, the browser then 
crashes.

If you load the image from the network, it plays fine up until the point that 
the entire image has been downloaded. This means that you can get further 
through the animation if you are on a slower link. The animation does not 
consistently stop decoding at the same place each time.

Reproducible: Always
Steps to Reproduce:
1. Visit http://aquarius.lunarpages.com/~island2/forum2/hack.gif

Actual Results:  
Image causes crash in Firefox 0.8 or fails to decode in the latest nightly 
build

Expected Results:  
Displayed the entire animation correctly (at least, i think what internet 
explorer does here is correct).

Comment 1

[WD]

I'm seeing the same symptoms, minus the crash.  
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040425 Firefox/0.8

Comment 2

[tor]

Attachment: keep animation proceeding error in gif

Comment 3

[ArronM (:paper)]

Comment on attachment 147079 [details] [diff] [review]
keep animation proceeding error in gif

tested on Win2k, image works with patch.  Couldn't test the ::WriteForm code,
but it looks okay.

Comment 4

[N. Thomas Posthuma]

The first animated GIF in this page loads fine usually, but if you scroll down
and then scroll up the images becomes broken, then Firefox immediately crashes.
 No problem with the page in IE 6.0.
NOTE: Has not been tested in a nightly build. Using Firefox 0.8 on Win NT5.1.
The crash also mysteriously causes the clipboard to clear out.

http://www.inklineglobal.com/adsales/arcamax/mb_index_ezine3.html
(yeah I know, it's an ad...)

Comment 5

[tor]

Checked in.

Comment 6

[N. Thomas Posthuma]

Problem definately patched in nightly.