241960 - Trunk crash [@ nsPop3Sink::EndMailDelivery]

Status: RESOLVED WORKSFORME

(MailNews Core :: Networking: POP, defect)

Description

[timeless]

12   nsPop3Sink::EndMailDelivery   3 

     Crash date range: 25-APR-04 to 25-APR-04
     Min/Max Seconds since last crash: 5 - 6
     Min/Max Runtime: 49492 - 49498
 
     Count   Platform List 
     2   [Windows 98 4.10 build 67766446]   
 
     Count   Build Id List 
     2   2004042307
 
     No of Unique Users         1

 Stack trace(Frame) 

	 nsPop3Sink::EndMailDelivery
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Sink.cpp
 line 259] 
	 nsPop3Protocol::GetMsg
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Protocol.cpp
 line 2406] 
	 nsPop3Protocol::ProcessProtocolState
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Protocol.cpp
 line 3491] 
	 nsMsgProtocol::OnDataAvailable
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/util/nsMsgProtocol.cpp
 line 326] 
	 nsInputStreamPump::OnStateTransfer
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/netwerk/base/src/nsInputStreamPump.cpp
 line 437] 
	 nsInputStreamPump::OnInputStreamReady
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/netwerk/base/src/nsInputStreamPump.cpp
 line 338] 
	 nsInputStreamReadyEvent::EventHandler
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/io/nsStreamUtils.cpp
 line 215] 
	 PL_HandleEvent
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c
 line 693] 
	 PL_ProcessPendingEvents
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c
 line 631] 
	 _md_EventReceiverProc
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c
 line 1434] 
	 KERNEL32.DLL + 0x24407 (0xbff94407)  
	 0x0064806e   

For reference:
326 nsPop3Sink::ReleaseFolderLock()
327 {
328   nsresult result = NS_OK;
329   if (!m_folder) 
330     return result;

For crashing:

228 nsPop3Sink::EndMailDelivery()
229 {
...
248   nsresult rv = ReleaseFolderLock();
249   NS_ASSERTION(NS_SUCCEEDED(rv),"folder lock not released successfully");
250 
251   PRBool filtersRun;
252   m_folder->CallFilterPlugins(nsnull, &filtersRun); // ??? do we need msgWindow?
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ where i'd want to crash
253   PRInt32 numNewMessagesInFolder;
254   // if filters have marked msgs read or deleted, the num new messages count  
255   // will go negative by the number of messages marked read or deleted,
256   // so if we add that number to the number of msgs downloaded, that will give
257   // us the number of actual new messages.
258   m_folder->GetNumNewMessages(PR_FALSE, &numNewMessagesInFolder);
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ where we actually crashed

I suppose the crash could stem from filterplugins accidentally dropping a ref on
the folder. problem is, that code doesn't seem get a reference to the folder.

jay: do you have contact info for this person?

Comment 1

[Robert Accettura [:raccettura]]

David may be a good persion to ask about this one.

Comment 2

[David :Bienvenu]

taking. I highly doubt that the m_folder object has been deleted. It might have
been nulled out, I guess...

Comment 3

[Robert Accettura [:raccettura]]

Is this in the 1.7 branch?  Or just the trunk?  If branch, we should nominate
for blocking.  

Comment 4

[David :Bienvenu]

I only see it in the trunk logs. It seems to be happening to one particular
user...I don't think anyone could be clearing m_folder, since no one calls
SetFolder(nsnull) - I suppose it's possible the filter plugin might be making
the pop3sink go away, though I don't know how that could be...

Comment 5

[Jay Patel [:jay]]

I only see 3 incidents in Talkback data.  All are with the same Trunk build and
none of them have an email address specified.

I'll keep an eye out for any incoming user info for this crash so we can try to
find out more.

Comment 6

[Jay Patel [:jay]]

Haven't seen any of these crashes in the latest Talkback data.  Marking WFM. 
Please reopen if anyone is able to reproduce this with a recent release/nightly.