241978 - crash starting Firefox without migrating Seamonkey profile

Status: RESOLVED WORKSFORME

(Firefox :: Migration, defect, P2)

Description

[Dan M]

Have at least one Seamonkey profile on your machine, no Firefox profile. Start
Firefox. In the dialog inviting you to select a profile to migrate, select "New"
then "Next >". It crashes here

void GetMigrateDataFromArray(MigrationData* aDataArray,
                             PRInt32 aDataArrayLength, 
                             PRBool aReplace,
                             nsILocalFile* aSourceProfile, 
                             PRUint16* aResult)
{
  ...
  for (cursor = aDataArray; cursor < end && cursor->fileName; ++cursor) {
    // When in replace mode, all items can be imported. 
    // When in non-replace mode, only items that do not require file replacement
    // can be imported.
    if (aReplace || !cursor->replaceOnly) {
      aSourceProfile->Clone(getter_AddRefs(sourceFile));
...

because aSourceProfile is null. It's been doing this since day one, early March
or so.

Comment 1

[José Jeria]

Installed Firefox on my sister computer (that never had any Mozilla product
installed on it) and I got a crash during the migration process (IE migration). 

Not 100% if this is the same bug though.

Comment 2

[Dan M]

That would be a different bug. This one can happen only when you have at least
one Mozilla profile for Firefox to  migrate. Other than that for me it's well
behaved: I haven't seen an unreliable migration crash. Perhaps it's something in
your IE data...

And did I mention the assertion from the memory manager complaining about a
requested zero-size memory allocation?

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

crashing, blocking0.9+

Comment 4

[Benjamin Smedberg]

I think I fixed this on the aviary 1.0 branch. Can you please try a branch build
(do we have branch nightlies yet?).

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

I cannot for the life of me reproduce this in any of my branch builds in any
configuration. 

Comment 6

[Dan M]

You've moved the code. My 20040527 Windows branch build still crashes.

1) Have a working Mozilla profile
2) Have no Firefox profile, or rename it
3) Launch Firefox
4) File Menu -> Import
5) Netscape 6, 7 or Mozilla 1.x, Next
6) new, Next

Same code, same crash, but reaching it is considerably more obtuse in recent
builds. Since it's no longer presented as a startup option, it's not nearly as bad.

Sorry I haven't had a chance to test with an Aviary branch.

Comment 7

[Dan M]

D'oh. That's my 20040527 trunk build. I'll take your word about the branch.

Comment 8

[Wayne Mery (:wsmwk)]

=> WFM per comment 5, 7