Firefox trunk build breaks in migration code on OS/2

RESOLVED FIXED

Status

()

Firefox
Migration
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: jhp (no longer active), Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

14 years ago
Breaks when building the nsOperaProfileMigrator.cpp.
(Reporter)

Comment 1

14 years ago
Created attachment 147269 [details] [diff] [review]
patch to disable Opera migrator

For now, disable the Opera migrator on OS/2.

There was a version of Opera available for OS/2, but that was version 5, and
this code seems to only reference Opera 6.  Ben, will this code work with
versions of Opera prior to version 6?

Kaply, do you think it is even worthwhile getting this to work on OS/2?  Do we
have any customers that use/used Opera?

Comment 2

14 years ago
we're presuming it works w/ older versions of opera for beos :)

Comment 3

14 years ago
Why can't we compile the code?

What actually breaks?
(Reporter)

Comment 4

14 years ago
What breaks is that the Opera defines at the top of nsOperaProfileMigrator.cpp
are only defined for Unix, Mac, and Win32, but is referrenced in the code for
all platforms.

Comment 5

14 years ago
Comment on attachment 147269 [details] [diff] [review]
patch to disable Opera migrator

r=mkaply
Attachment #147269 - Flags: review+

Comment 6

14 years ago
Created attachment 147344 [details] [diff] [review]
XUL change

The XUL had no default, so it did nothing on platforms other than XP_UNIX and
XP_MAC

Comment 7

14 years ago
Fixes in to branch and trunk.

Note we still need to actually make migration work for OS/2.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.