User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113 patch coming Reproducible: Always Steps to Reproduce:
Created attachment 147369 [details] [diff] [review] if the document is XHTML, let's check the namespace
Why not use NS_HTML_NAMESPACE from nsIElementFactory.h? And maybe fix indentation?
Created attachment 147393 [details] [diff] [review] uses NS_HTML_NAMESPACE If this is ok, could you bz or jst check this in?
Attachment #147369 - Attachment is obsolete: true
Comment on attachment 147393 [details] [diff] [review] uses NS_HTML_NAMESPACE maybe r+sr is enough
Comment on attachment 147393 [details] [diff] [review] uses NS_HTML_NAMESPACE + if (IsXHTML()) + rv = GetElementsByTagNameNS(NS_LITERAL_STRING(NS_HTML_NAMESPACE), + NS_LITERAL_STRING("frameset"), + getter_AddRefs(nodeList)); + else + rv = GetElementsByTagName(NS_LITERAL_STRING("frameset"), getter_AddRefs(nodeList)); Bad next-line indentation. r+sr=jst I fixed the indentation, and also consolidated some error handling to save a byte or two of code. Checking in.
Erm... Won't NS_LITERAL_STRING(NS_HTML_NAMESPACE) break on compilers that use Lfoo to implement NS_LITERAL_STRING??
Do we care? IIRC we do that elsewhere too. This is checked in, all tinderboxes are green, including all ports. Marking FIXED. Reopen if you think this is worth changing.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Assignee: general → Olli.Pettay
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.