Closed Bug 242157 Opened 20 years ago Closed 20 years ago

Deal with WSDL that has a <types> element with more than one <schema> children

Categories

(Core Graveyard :: Web Services, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: keeda, Assigned: keeda)

Details

(Keywords: fixed1.7)

Attachments

(2 files, 1 obsolete file)

If you try to mix RPC and Literal methods in the same service when using asmx
webservices, Visual Studio will generate a WSDL that has two schema elements
under the types element. It puts the SOAP RPC encoded types under one and the
ones needed for the Literal stuff under the other, and uses different
targetnamespaces. I will shortly attach an example wsdl generated from a
minimized C# testcase.

What VS is doing here looks prefectly legal and logical to me. But our WSDL
implementation assumes only one significant schema element under <types>. This
causes us to fail later on when processing the relevant <part> since the type
never got loaded by the schemaloader.

I have a fix.
Attached file Example wsdl
This was generated by the .Net wsdl.exe. It cant be loaded by mozilla.
Attached patch Easy fix (obsolete) — Splinter Review
Comment on attachment 147375 [details]
Example wsdl

Err .... oops
Attachment #147375 - Attachment is patch: false
Attachment #147375 - Attachment mime type: text/plain → text/xml
Sorry for the spam. The last patch contained unrelated stuff from another bug,
I forgot to save the edited patch before submitting. Ignore that.
Attachment #147376 - Attachment is obsolete: true
Attachment #147377 - Flags: review?(peterv)
Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

I think we'll need to handle xs:import elements too here. Could you add a //
XXX comment if you think so too?
Attachment #147377 - Flags: review?(peterv) → review+
Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

Yeah, its possible to have import over there. I'll add the comment. 

Thanks, for the review. 

jst, could you please sr.
Attachment #147377 - Flags: superreview?(jst)
Maybe file a bug about handling import there too? :)
Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

sr=jst
Attachment #147377 - Flags: superreview?(jst) → superreview+
Filed bug 242260 on the iport issue.

Checked in on trunk -> Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

Trivial change that gets us one step closer to working with more web service
implementations out there. Nominating for 1.7.
Attachment #147377 - Flags: approval1.7?
Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

a=chofmann for 1.7
Attachment #147377 - Flags: approval1.7? → approval1.7+
Fix landed on the 1.7 branch.
Keywords: fixed1.7
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: