242215 - Remove DEFAULT_PLUGINFINDER_URL/szDefaultPluginFinderURL from os2/win plugin samples

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Serge Gautherie (:sgautherie)]

This bug is spun off from bug 217089,
in which timeless wrote
{{
well, i wouldn't mind killing plugin finder, but this isn't the way to do it.

this change should be made to both windows and os2 plugins.
}}

This applies to removing DEFAULT_PLUGINFINDER_URL/szDefaultPluginFinderURL
{{
<http://lxr.mozilla.org/mozilla/search?string=DEFAULT_PLUGINFINDER_URL>
DEFAULT_PLUGINFINDER_URL
/modules/plugin/samples/default/os2/plugin.cpp, line 56 -- static char
szDefaultPluginFinderURL[] = DEFAULT_PLUGINFINDER_URL;
/modules/plugin/samples/default/os2/plugin.h, line 111 -- #define
DEFAULT_PLUGINFINDER_URL "http://plugins.netscape.com/plug-in_finder.adp"
/modules/plugin/samples/default/windows/plugin.cpp, line 57 -- static char
szDefaultPluginFinderURL[] = DEFAULT_PLUGINFINDER_URL;
/modules/plugin/samples/default/windows/plugin.h, line 117 -- #define
DEFAULT_PLUGINFINDER_URL "http://plugins.netscape.com/plug-in_finder.adp"

<http://lxr.mozilla.org/mozilla/search?string=szDefaultPluginFinderURL>
szDefaultPluginFinderURL
/modules/plugin/samples/default/os2/plugin.cpp, line 56 -- static char
szDefaultPluginFinderURL[] = DEFAULT_PLUGINFINDER_URL;
/modules/plugin/samples/default/os2/plugin.cpp, line 326 -- urlToOpen =
szDefaultPluginFinderURL;
/modules/plugin/samples/default/os2/plugin.cpp, line 396 --
szDefaultPluginFinderURL,
/modules/plugin/samples/default/windows/plugin.cpp, line 57 -- static char
szDefaultPluginFinderURL[] = DEFAULT_PLUGINFINDER_URL;
/modules/plugin/samples/default/windows/plugin.cpp, line 369 -- urlToOpen =
szDefaultPluginFinderURL;
/modules/plugin/samples/default/windows/plugin.cpp, line 451 --
szDefaultPluginFinderURL,
}}

timeless:
Could you give some details on what you had in mind ?

Comment 1

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Serge, is this still valid? Can we confirm or close it or move it to some more appropriate component?

Comment 3

[Serge Gautherie (:sgautherie)]

Still there:
http://mxr.mozilla.org/mozilla-central/search?string=DEFAULT_PLUGINFINDER_URL&case=on&find=%2Fmodules%2Fplugin%2Fdefault%2F
http://mxr.mozilla.org/mozilla-central/search?string=szDefaultPluginFinderURL&case=on&find=%2Fmodules%2Fplugin%2Fdefault%2F

Comment 4

[:Cykesiopka]

Can this be resolved...? MXR searches on m-c and c-c for DEFAULT_PLUGINFINDER_URL and szDefaultPluginFinderURL both turn up nothing...

Comment 5

[Benjamin Smedberg]

Yep, code is gone.