Closed
Bug 242301
Opened 21 years ago
Closed 20 years ago
Context menu's objectIsImage is totally bogus (and throws exceptions)
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Unassigned)
References
()
Details
Attachments
(1 file)
|
63 bytes,
text/html
|
Details |
There are two issues in this function:
1) If "type" is not set you'll get back null and then trying to call indexOf on
it will throw.
2) You'd be better off detecting an image by going through
nsIImageLoadingContent and looking for an actual image hanging off the node.
#1 is extremely bad -- it makes very broken context menus come up (think every
single item enabled).
You can test with the testcase (and patch) in bug 122685
|
Reporter | |
Comment 1•21 years ago
|
||
I meant bug 185714 (as the dependencies say).
|
|
Reporter | |
Comment 2•21 years ago
|
||
This breaks today's seamonkey build; no need for patch from bug 185714 or
anything.
|
||
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
|
||
Comment 3•20 years ago
|
||
This was fixed in bug 196380.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•