242305 - PAC: dnsDomainIs() is not explicitly matching to a DNS suffix

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[benc]

228 "function dnsDomainIs(host, domain) {\n" +
229 "    return (host.length >= domain.length &&\n" +
230 "            host.substring(host.length - domain.length) == domain);\n" +
231 "}\n" +

If domain is a string without a leading ".", then it still matches in some cases
that do not make sense.

Two cases that work:
www.mozilla.org, mozilla.org
www.mozilla.org, la.org

The first is probably not as bad as the second case.

This looks similar to several comments made about how domains are handled in "no
proxy for" (part of manual config).

The examples in the PAC documents all use "." at the front. Should we assume
people who do not put a "." meant for a "."?

If so, we could automaticaly add the missing dot before doing the string comparison.

If not, should we discard fail the comparision automatically?

I think we should modify the behavior somewhat, because of the problems w/ false
positives.

Comment 1

[Stefan Weiss [:sir_none]]

I have tested the reported way of work on IE 9 to 11 and actual Chrome
-> all this browsers work like firefox.

i checked also all specifications for PAC files that i could find, but there is no specific information for this case.

can we maybe close this bug, because it seems to be the normal behavior for actual browsers!!

Comment 2

[Patrick McManus [:mcmanus]]

based on compat report of comment 1, close as wontfix. Thanks stefan.weiss