Closed
Bug 242394
Opened 20 years ago
Closed 14 years ago
make installer not leak
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: ajschult784, Assigned: ajschult784)
References
Details
(Keywords: memory-leak, Whiteboard: [patchlove])
Attachments
(2 files)
9.22 KB,
text/plain
|
Details | |
5.94 KB,
patch
|
benjamin
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
The installer leaks quite a bit. Most, but not all, are shutdown leaks. I'll attach a valgrind leak log. Some of these would be fixed by the patch in bug 101471.
Assignee | ||
Comment 1•20 years ago
|
||
LEAK SUMMARY: definitely lost: 6902 bytes in 95 blocks. possibly lost: 732 bytes in 12 blocks. still reachable: 611930 bytes in 2365 blocks.
Assignee | ||
Comment 2•20 years ago
|
||
This fixes the installer leaks not fixed by the patch in bug 101741 except for the component duplicates, which I hope to fix in bug 242524. The leaks within gtk_init are unfixable. The other leaks in the valgrind log seem to be elsewhere in gecko.
Assignee | ||
Updated•20 years ago
|
Attachment #147599 -
Flags: review?(bsmedberg)
Updated•20 years ago
|
QA Contact: bugzilla → agracebush
Updated•20 years ago
|
Attachment #147599 -
Flags: review?(bsmedberg) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #147599 -
Flags: superreview?(dveditz)
Updated•20 years ago
|
Product: Browser → Seamonkey
Assignee | ||
Comment 3•18 years ago
|
||
*** Bug 333316 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Attachment #147599 -
Flags: superreview?(dveditz)
Comment 4•16 years ago
|
||
Comment on attachment 147599 [details] [diff] [review] patch sr=dveditz if we're still using this.
Attachment #147599 -
Flags: superreview+
Updated•15 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patchlove]
Updated•15 years ago
|
QA Contact: agracebush → xpi-packages
Comment 5•14 years ago
|
||
This is on old installer, which is gone.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•