2424 - Full-screen plug-in: throbber never stops

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Richard Cohn]

A full-screen plug-in should be an nsIDocumentViewer and support
kIDocumentViewerIID. I noticed this because the throbber never stops on a
full-screen plug-in. Stopping depends on getting an nsIDocumentViewer, which the
PluginViewerImpl is not.

Comment 1

[leger]

Setting all current Open/Normal to M4.

Comment 2

[Paul MacQuiddy]

per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Comment 3

[rubydoo123]

reassigning Greg Lynn as QA contact

Comment 4

[glynn]

Alex any update on this bug?  QA assigned to whitebox, gerardok

Comment 5

[Alex Musil]

It is true that the throbbing code only gets called if the viewer implements the
nsIDocumentViewer interface, but I do not think the solution is to make the
plugin viewer implement this (it is intended for a viewer that uses the layout
enginer to layout data).  An nsIContentViewer derived viewer should also stop
the throbber.  The relavent code is in nsWebShell::OnConnectionsComplete().

I'll figure out who to assign this to (it's whoever owns the webshell code).

There is also a crash that occurs in this same function (bug 1157) and it may be
related.

Comment 6

[Alex Musil]

Rick - who owns the webshell code?

Comment 7

[Alex Musil]

Nisheeth - can you take a look at this?

Comment 8

[Alex Musil]

Someone re-coded the logic for the dispatch of the all connections complete
notification and this is not fixed.

If you leave bugs alone long enough, they just fix themselves... :-)

Comment 9

[gerardok]

cohn, please could you verify this bug or provide a testcase to verify it.
Thanks!

Comment 10

[Richard Cohn]

Seems to work for me now.

Comment 11

[gem]

verified by reporter