Files fieldMapExport.* are unused and can be removed

RESOLVED FIXED

Status

SeaMonkey
MailNews: Address Book & Contacts
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Stefan Borggraefe, Assigned: Stefan Borggraefe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

17.81 KB, patch
neil@parkwaycc.co.uk
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
Are there any plans for these files or can they be removed? I could make the
patch in the latter case.
(Assignee)

Comment 1

14 years ago
Created attachment 148724 [details] [diff] [review]
Patch to remove the files

This code looks really ancient, is incomplete and isn't hooked up. Even if
someone decides to implement this feature in the future (Bug 116977) these
files would IMHO be of little use.

There's no reason to include them in our builds.
(Assignee)

Updated

14 years ago
Attachment #148724 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 2

14 years ago
Comment on attachment 148724 [details] [diff] [review]
Patch to remove the files

Sorry, this patch is not correct.
Attachment #148724 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 3

14 years ago
Created attachment 148726 [details] [diff] [review]
Next try
(Assignee)

Updated

14 years ago
Attachment #148724 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #148726 - Flags: review?(neil.parkwaycc.co.uk)

Updated

14 years ago
Attachment #148726 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Updated

14 years ago
Attachment #148726 - Flags: superreview?(bienvenu)

Updated

14 years ago
Attachment #148726 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 4

14 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Summary: Files fieldMapExport.* are unused and can probably be removed → Files fieldMapExport.* are unused and can be removed

Comment 5

14 years ago
Actually the second patch was not correct either, it deleted the contents rather
than removing the files (you need to cvs rm + cvs diff -N).
(Assignee)

Comment 6

14 years ago
(In reply to comment #5)
> Actually the second patch was not correct either, it deleted the contents rather
> than removing the files (you need to cvs rm + cvs diff -N).

Ah, I wasn't sure how to make a diff when removing files. I just replaced the
files to remove with empty files locally so their content show up in the diff.
On checkin I did the actual cvs rm.

I just added -N to the diff line in my .cvsrc. Thanks for the hint! :-)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.