24253 - [REGRESSION] Redo adds newlines instead of redoing.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[kinmoz]

In the 01/18/2000 WinNt and Mac builds, redoing typed text adds new lines to the
content.

To reproduce:

  1. Start up a blank editor window.
  2. Type some text.
  3. Undo everything you just typed. (CTRL-Z or Edit->Undo)
  4. Now try to Redo everything.

You will notice that you will get a blank line for every time you try to redo.
If you do enough of them vertical scrollbars will appear on the right side of
the window.

Comment 1

[kinmoz]

Reassigning to [e-mail].

Comment 2

[kinmoz]

Accepting bug.

I have a fix for this that was reviewed by [e-mail].

Comment 3

[kinmoz]

Fix checked in and should appear in the 01/19/2000 QA builds:

    mozilla/editor/base/nsEditor.cpp
    mozilla/editor/base/nsEditor.h
      - Added IsMozEditorBogusNode() method.

    mozilla/editor/base/nsTextEditRules.cpp
      - Modified CreateBogusNodeIfNeeded() to check if bodyChild is a
        MozEditorBogusNode so that it doesn't create more than one.
      - Modified DidUndo() and DidRedo() to use IsMozEditorBogusNode().

r=[e-mail]

Comment 4

[sujay]

will verify in 1/19 build.

Comment 5

[sujay]

verified in 1/19 build.