[REGRESSION] Redo adds newlines instead of redoing.

VERIFIED FIXED in M13

Status

()

Core
Editor
P3
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: kinmoz, Assigned: kinmoz)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: will verify in 1/19 build.)

(Assignee)

Description

18 years ago
In the 01/18/2000 WinNt and Mac builds, redoing typed text adds new lines to the
content.

To reproduce:

  1. Start up a blank editor window.
  2. Type some text.
  3. Undo everything you just typed. (CTRL-Z or Edit->Undo)
  4. Now try to Redo everything.

You will notice that you will get a blank line for every time you try to redo.
If you do enough of them vertical scrollbars will appear on the right side of
the window.
(Assignee)

Updated

18 years ago
Assignee: jfrancis → kin
Target Milestone: M13
(Assignee)

Comment 1

18 years ago
Reassigning to kin@netscape.com.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

18 years ago
Accepting bug.

I have a fix for this that was reviewed by sfraser@netscape.com.
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

18 years ago
Fix checked in and should appear in the 01/19/2000 QA builds:

    mozilla/editor/base/nsEditor.cpp
    mozilla/editor/base/nsEditor.h
      - Added IsMozEditorBogusNode() method.

    mozilla/editor/base/nsTextEditRules.cpp
      - Modified CreateBogusNodeIfNeeded() to check if bodyChild is a
        MozEditorBogusNode so that it doesn't create more than one.
      - Modified DidUndo() and DidRedo() to use IsMozEditorBogusNode().

r=sfraser@netscape.com

Updated

18 years ago
Whiteboard: will verify in 1/19 build.

Comment 4

18 years ago
will verify in 1/19 build.

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 5

18 years ago
verified in 1/19 build.
You need to log in before you can comment on or make changes to this bug.