Event/Tasks with UID/Categories including special characters are not displayed in month and multiweek view

RESOLVED FIXED

Status

Calendar
Sunbird Only
--
minor
RESOLVED FIXED
14 years ago
11 years ago

People

(Reporter: Eric Belhaire, Assigned: Eric Belhaire)

Tracking

Details

Attachments

(3 attachments)

(Assignee)

Description

14 years ago
Event which UID includes special characters like "/" (imported events) are not
displayed in month and multiweek views and generates a JS error. 

This is due to unused code and I will send an easy fix.
(Assignee)

Comment 1

14 years ago
Created attachment 147616 [details] [diff] [review]
1 line suppressed in monthView.js and multiweekView.js
(Assignee)

Updated

14 years ago
Attachment #147616 - Flags: first-review?(mostafah)

Comment 2

14 years ago
Comment on attachment 147616 [details] [diff] [review]
1 line suppressed in monthView.js and multiweekView.js

r=mostafah
Attachment #147616 - Flags: first-review?(mostafah) → first-review+

Comment 3

14 years ago
Patch checked in.
Thanks
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 4

14 years ago
Uncommenting the line in files monthView.js and multiweekView.js only solves the
problem for displaying events only. If 'Tasks in View' is selected for multiweek
view, I can see only a few tasks instead of all tasks and all the events. This
problem concerns all calendars in my container as long as calendars with tasks
are active. When all calendars with tasks are disabled, the events of the other
calendars are shown as expected.

Thunderbird version 0.6 (20040502), Windows 98SE, calendar nightly build
2004040813-cal

Comment 5

14 years ago
I forgot to mention that with TB 0.6 and cal 2004040813 the colors of the
different calendars in the 'Calendars' tab disappeared. Could this be related to
not shown events?
(Assignee)

Comment 6

14 years ago
(In reply to comment #4)
> Uncommenting the line in files monthView.js and multiweekView.js only solves the
> problem for displaying events only. If 'Tasks in View' is selected for multiweek
> view, I can see only a few tasks instead of all tasks and all the events. 
What do you mean by "uncommenting" ?
You want to cancel the patch application  ? You think it is corrupted ?
Is there anay message in the Javascript console ?
Could you attach an example calendar which tasks leads to those errors ?

Comment 7

14 years ago
Created attachment 148304 [details]
Calendar containing a task with a category with blanks

(In reply to comment #6)
> What do you mean by "uncommenting" ?
> You want to cancel the patch application  ? You think it is corrupted ?
> Is there anay message in the Javascript console ?
> Could you attach an example calendar which tasks leads to those errors ?

Sorry, I used 'uncommenting' instead of commenting out! The patch was ok.

If 'Tasks in View' is selected, tasks and events are not displayed correctly if
there is a task with a category containing a blank. The attachment contains an
example calendar with such a task. If this calendar is activated, all events
from other calendars are disappearing from the main window and the javascript
console displays:
Error: uncaught exception: [Exception... "String contains an invalid character"
 code: "5" nsresult: "0x80530005 (NS_ERROR_DOM_INVALID_CHARACTER_ERR)" 
location: "chrome://calendar/content/multiweekView.js Line: 440"]

Commenting out the lines 438-441 in multiweekView.js
438  if( calendarToDo.categories && calendarToDo.categories != "" )
439  {
440    eventBox.setAttribute( calendarToDo.categories, "true" );
441  }
as proposed by Eric solves the problem.
(Assignee)

Updated

14 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

14 years ago
reopened with extension to similar problem with categories
A patch will be submitted.
Status: REOPENED → ASSIGNED
Summary: Event with UID including special characters are not displayed in month and multiweek view → Event/Tasks with UID/Categories including special characters are not displayed in month and multiweek view
(Assignee)

Comment 9

14 years ago
Created attachment 148316 [details] [diff] [review]
patch of multiweekView.js fo correct tasks (ToDos) categories problem
(Assignee)

Updated

14 years ago
Attachment #148316 - Flags: first-review?(mostafah)

Updated

14 years ago
Attachment #148316 - Flags: first-review?(mostafah) → first-review+

Comment 10

14 years ago
Patch checked into CVS. Thanks
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago14 years ago
Resolution: --- → FIXED
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.