Closed
Bug 242601
Opened 21 years ago
Closed 21 years ago
.xpi packages don't install anymore: Software Installation dialog doesn't show up. Install broken.
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: firemotion+mozilla, Unassigned)
References
()
Details
(Keywords: regression)
On this trunk build:
Steps to reproduce: Go to http://3rdhand.info/mozilla/home/home.xpi
Expected: Software Installation Dialog should show up to install the xpi package.
Actual result: Nothing happens.
This broken since: 2004-05-04-09-trunk/
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040504
It still worked using: 2004-05-03-10-trunk/
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040503
or even the 2004-05-04-09-1.7/ branch.
However, I can't find any changes with the XPInstall Engine component that
could've caused this in the last few days. I don't know if this is Windows-only
either.
Comment 1•21 years ago
|
||
Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040504
Updated•21 years ago
|
Severity: normal → major
Comment 2•21 years ago
|
||
Dialog showed up on the URL with 2004-05-04-07-trunk ZIP build,Win-2K(SP4).
What is the difference between 2004-05-04-07-trunk and 2004-05-04-09-trunk?
Next change?
> 2004-05-04 03:04 mozilla/ browser/ installer/ windows/ browser.jst
> 2004-05-04 03:04 mozilla/ browser/ components/ shell/ src/
nsWindowsShellService.cpp
> add xpinstall content type settings to shell service and installer registrations
Comment 3•21 years ago
|
||
Stuff in mozilla/browser would only affect FireFox, this is filed against the
Suite (correctly, given the quoted UA strings).
Comment 4•21 years ago
|
||
The check-in for bug 242111 also touched XPInstall, but looks trivial and correct.
Comment 5•21 years ago
|
||
wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a) Gecko/20040504
BuildID 2004050407
I just installed LiveHTTPHeaders, all as usual.
Had it installed before, but after installing a new Mozilla it is gone, so
reinstall required.
http://livehttpheaders.mozdev.org/installation.html#
Reporter | ||
Comment 6•21 years ago
|
||
* A small PS:
The build ID of the offending build was 2004050407, and it still worked with
2004050308, both are trunk builds.
* In reply to comment #4:
Bug #242111 changes something in attachment #147438 [details] [diff] [review], excerpt:
=====
Index: xpinstall/src/nsXPInstallManager.cpp
[..]
// Don't launch installs while page is still loading
PRBool isPageLoading = PR_FALSE;
nsCOMPtr<nsPIDOMWindow> piWindow = do_QueryInterface(mParentWindow);
- if (piWindow)
- piWindow->IsLoadingOrRunningTimeout(&isPageLoading);
-
- if (isPageLoading)
+ if (piWindow && piWindow->IsLoadingOrRunningTimeout())
rv = NS_ERROR_FAILURE;
else
{
=====
I'm not a Mozilla developer myself, so I don't know if this might've broken it
or not, although it does look that it could've broken something -- when clicking
on a link, and when the browser requests the (in this case: .xpi file), isn't
the status "Loading" at that point? But it doesn't want to install when it's
loading, so then what does it do with the .xpi file? Nothing?
* In reply to comment #5:
I tried installing LiveHTTPHeaders, so I clicked on one of the links. It worked
once: the dialog showed up, but after that I tried it again and again, and it
doesn't show up anymore.
http://livehttpheaders.mozdev.org/installation.html or try
http://downloads.mozdev.org/livehttpheaders/livehttpheaders-0.8.xpi
Summary: xpi packages don't install anymore - Software Installation dialog doesn't show up → .xpi packages don't install anymore: Software Installation dialog doesn't show up. Install broken.
Comment 7•21 years ago
|
||
(In reply to comment #6)
> -- when clicking
> on a link, and when the browser requests the (in this case: .xpi file), isn't
> the status "Loading" at that point? But it doesn't want to install when it's
> loading, so then what does it do with the .xpi file? Nothing?
When clicking on a .xpi installer link, you should be asked if you *really* want
to install.
You don´t get the IE comfort of automatic installation of dialers, worms and
other useful utilities for automatic transfer of passwords, accounts, files to
interested or uninterested parties. That could also be made with XPI, but you
have to acknowledge the install.
>
> * In reply to comment #5:
>
> I tried installing LiveHTTPHeaders, so I clicked on one of the links. It worked
> once: the dialog showed up, but after that I tried it again and again, and it
> doesn't show up anymore.
> http://livehttpheaders.mozdev.org/installation.html
I retried the link above with yesterdays nightly, to no avail. But I had
installed the xpi yesterday, and used LHTTPH today, before reading your comment,
and deciding to try to install ontop. Didn´t succeed, but that could have many
reasons, scarcity of resources, the running LiveHTTPHeaders, etc.
I installed todays nightly, BuildID 2004050509 ontop yesterdays, using the full
installer.Then I opened this bug, used your link to load the installation page,
and clicked on install 0.8 link. After 10 seconds the dialog came up, asking me
for permission to install, I granted, and clicked again on install, and while
the download of the first was running, a second dialog came up, and I canceled
the second, the first went on. Retried with a third, and canceled, all was well.
When the download finished, I was told to restart Mozilla.
I canceled Mozilla, and some more open Mozilla windows, and the saw a small
Mozilla Message which was hidden behind the big windows, telling me Install was
successful. I restarted Mozilla, started Livehttpheaders, and retried install of
LiveHTTPheaders, dialog came up, and I canceled.
I´m often installing LiveHTTPheaders, and 0.8 is old now, so there are no
changes on the LHHTPH 0.8 side. Often I´ve had to wait long, or click multiply,
until the install started, and then, when I acknowledged, the next dialogs came
up, as I had clicked multiple times. I normally cancel the others, but iirc I
also once installed twice, without problems.
Maybe restart of Mozilla is a problem if you use the quickstart option, I don´t
know.
Do you have other extensions installed?
Did you try in a fresh, new profile, without other extensions and themes installed?
Reporter | ||
Comment 8•21 years ago
|
||
Issue magically disappeared using: Build ID 2004050509 (Trunk),
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040505
Maybe 2004050407 was just a bad build. Please confirm if WFM using a newer build
than 2004050407 (Trunk).
Comment 9•21 years ago
|
||
(In reply to comment #8)
> Issue magically disappeared using: Build ID 2004050509 (Trunk),
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040505
>
> Maybe 2004050407 was just a bad build. Please confirm if WFM using a newer build
> than 2004050407 (Trunk).
wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a) Gecko/20040506
in my comment #5 it was WFM BuildID 2004050407,
so I don´t think BuildID 2004050407 was a bad build,
But I´m resolving this bug as WFM acording to your comment #8
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WORKSFORME
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•