1.26 KB, patch
|Details | Diff | Splinter Review|
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040505 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040505 the function art_realloc in libart_lgpl doesn't return a value which causes compiler warnings and could cause runtime errors. The attached patch fix this. Reproducible: Always Steps to Reproduce: -
Created attachment 147866 [details] [diff] [review] bugfix for non-void function doesn't return a value
Fix checked in. Instead of your patch, I have just inserted a 'return' into the definition of art_realloc, though. We want to keep these as functions (and not macros) so that we can mix a debug build of libart with a non-debug build of Mozilla (or vice-versa): Under Windows the debug & non-debug heaps are incompatible, so we need to make sure that the art_malloc etc. always operate on the one or the other independent of where they are called from.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
this was my first fix too. But then I looked at the gnome libart_lgpl and found the changes I made here. But it's OK as it is.
You need to log in before you can comment on or make changes to this bug.