242909 - pnwin.cpp doesn't compile with win32/cygwin/msvc due to error in code

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Marcin Zdun]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; pl-PL; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; pl-PL; rv:1.6) Gecko/20040206 Firefox/0.8

Code in embedding/browser/activex/src/plugin/npwin.cpp has a strange order of
lines. It requires access to functions without properly declaring their
prototypes (lines 34-43). Putting the prototype of NPP_GetJavaClass and placing
code after NPN_GetJavaEnv (eg. at the end of file) fixes it.

Reproducible: Always
Steps to Reproduce:
1. Do everything to setup your win/cygwin environment as said in docs on
building under win32
2. make -f client.mk checkout
3. make -f client.mk build

Actual Results:  
The compiler gave up on embedding/browser/activex/src/plugin/npwin.cpp

Expected Results:  
Build the Mozilla, I guess :)

Comment 1

[timeless]

Attachment: ifdef OJI. update npapi.h to current

Comment 2

[Adam Lock]

Comment on attachment 147915 [details] [diff] [review]
ifdef OJI. update npapi.h to current

I copied npwin.cpp from a plugin SDK circa 1998. I'd prefer to see the plugin
makefile fixed up to use the current npwin.cpp
(http://lxr.mozilla.org/seamonkey/source/modules/plugin/samples/default/windows
/npwin.cpp) if that compiles okay rather than fix up an old one.

Comment 3

[Darin Fisher]

Comment on attachment 147915 [details] [diff] [review]
ifdef OJI. update npapi.h to current

please re-request SR once you have module owner approval or something
equivalent to that.

Comment 4

[Ed Morley [:emorley]]

The ActiveX embedding API was removed in bug 662023 and friends, making this INVALID.

[Filter bugspam on activexinvalid]