24292 - Lots of style changed reflow commands

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[troy]

Rod, if you load up http://www.cnn.com/ you'll notice lots of StyleChanged
incremental reflow commands targeted at a nsListControlFrame frame

There are also lots of StyleChanged reflow commands targeted at a
nsGfxButtonControlFrame frame as well

All of these incremental reflows slow down the document load, of course

Comment 1

[rods (gone)]

Troy, I need a some help here. Is the ListControlFrame responsible for all the
StyleChange reflows? Or is it that it doesn't handle them efficiently? What do
you think is the problem in the ListControlFrame that I should look at fixing?
Thanks.

Comment 2

[rods (gone)]

setting milestone to M14

Comment 3

[troy]

I don't know why the StyleChanged() reflow commands are happening. Probably
because the style system thinks the style context needs to be re-resolved
(although I don't know the answer to why of that question either).

You're probably handling them efficiently, unfortunately, StyleChanged is a very
inefficient process because it requires reflowing that entire frame subtree
(recursively, no shortcuts).

I'll take a look and see if I can tell why the style system is generating the
StyleChanged reflow commands. I was kind of hoping you knew. :-)

Comment 4

[rods (gone)]

Troy,
The Combobox is changing incremental reflows to StyleChanged reflows, this has
been there a very long, long time. I am not even sure why.

Comment 5

[rods (gone)]

Fix is in my tree

Comment 6

[ckritzer (gone)]

Is the fix going into M14?  And how would one go about testing this bug?  From
the comments it sounds like more of an under-the-covers type of bug that doesn't
manifest itself in an obvious fashion.

I could, however, be complete wrong.  Any comments/suggestions?

Comment 7

[rods (gone)]

changing to M15

Comment 8

[rods (gone)]

This has been fixed with my lastest checkin

Comment 9

[bsharma]

Updating QA contact.

Comment 10

[luis rincon]

Verified build 2001080608 os:winNT