Closed Bug 242926 Opened 16 years ago Closed 12 years ago

WinXP 64Bit Edition (AMD64/IA64) support for mozilla/directory/c-sdk

Categories

(Directory :: LDAP C SDK, enhancement)

x86
Windows XP
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421

Currently mozilla/directory/c-sdk doesn't support WinXP 64 Bit (AMD64 / IA64).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Blocks: 237202
Assignee: mcs → m_kato
Summary: WinXP 64Bit Edtion (AMD64/IA64) support for mozilla/directory/c-sdk → WinXP 64Bit Edition (AMD64/IA64) support for mozilla/directory/c-sdk
I am not an expert on IA64, but it seems to me that ia64 does not imply _WIN64.
 HP/UX for example runs on ia64 CPUs.
There's a Windows 64 for Itanium which is not AMD Architecture.
And Linux and Windows (AMD architecture) run on A64/Opteron.
Attached patch patch of mozilla/directory/c-sdk (obsolete) — Splinter Review
Attachment #147889 - Attachment is obsolete: true
Any update to this?  I note that the free MSVC + Platform SDK has support for intel 64bit and amd 64bit.  I'm currently working on the windows build (using cygwin) so I might be able to sneak this in if you can test it.
At the moment, the code base for the Branch is broken for building on the PSDK.
The breakage occured probably within the last six weeks as I tried building
but it failed on something. I was planning on waiting for the final 1.5.0.1
source code before trying to isolate the problem to get it resolved so that a
fix would be possible.

I've also tried building with VS2005 but that, of course, has the same problems
and some additional ones that are also in the 32-bit build on VS2005. I've been
busy with Win32 stuff for a while.
Any update on this?
(In reply to comment #7)
> Any update on this?

What are you looking to do? Build on 1.5, 2.0 or later? I can build on 1.5 but I'm using VS2005 and the process requires a lot of pieces that have to be done by hand. I do plan to try building on 2.0 but am busy with debugging a Win32 problem right now.
I can probably get some fixes into the ldap c sdk configure/makefiles for this, but I don't have a Win64 machine to test with.
Attached patch patch for current trunk (obsolete) — Splinter Review
Attachment #169204 - Attachment is obsolete: true
Attachment #322259 - Flags: superreview?(mcs)
Attachment #322259 - Flags: review?(richm)
Comment on attachment 322259 [details] [diff] [review]
patch for current trunk

I do not have super reviewer status, but if the changes are just landing on the LDAP C SDK trunk, historically we have not required a super review.

I do not know a lot about 64 bit Windows, but looking at NSPR's configure code they define USE_64 in a few places.  Maybe the same thing should be done for the LDAP C SDK?  See:

http://lxr.mozilla.org/seamonkey/source/nsprpub/configure.in#1648
Attached patch a patch v4Splinter Review
Attachment #322259 - Attachment is obsolete: true
Attachment #322259 - Flags: superreview?(mcs)
Attachment #322259 - Flags: review?(richm)
IA64 in the title should be changed to EM64T. IA64 is Intel's Itanium architecture. Intel's 64-bit x86 architecture is called EM64T.
Looks ok to me.
Attachment #332658 - Flags: review?(mcs)
Attachment #332658 - Flags: review?(mcs) → review+
Comment on attachment 332658 [details] [diff] [review]
a patch v4

OK.
checked in
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.