Closed
Bug 242952
Opened 21 years ago
Closed 21 years ago
Rephrase browser check label in preferences and remove unused dtd entity.
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: u81239, Assigned: bugzilla)
Details
Attachments
(1 file)
1.05 KB,
patch
|
mconnor
:
review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
The patch attached does 2 things in the Options / General window:
- Rephrase browser check text checkForDefault.label from "&brandShortName;
should check to see if it is the default browser when starting." to "Let
&brandShortName; check whether it is the default browser when starting.". This
is both better formulated, and fits on one single line instead of two.
- Remove unused fontsInfo.caption and rename fonts.label to fontsInfo.caption.
This should reduce the browser size a little :).
See whether you like both, or at least the second.
~Grauw
Reproducible: Always
Steps to Reproduce:
Attachment #147909 -
Flags: review?(mconnor)
Comment 2•21 years ago
|
||
Comment on attachment 147909 [details] [diff] [review]
Patch which does the mentioned things...
I don't think the new wording is correct, or better formulated. A single line
or two is based on font size as well, larger fonts it won't matter.
As for the unused .dtd entries, it'd be really good to see a bug (and even a
patch) removing all of the cruft we no longer use, would be really nice to ease
the localization workload if possible.
Attachment #147909 -
Flags: review?(mconnor) → review-
Comment 3•21 years ago
|
||
I think the existing wording is good, but I would love to see that followup bug :)
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
Comment 4•18 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in
before you can comment on or make changes to this bug.
Description
•