Closed
Bug 242977
Opened 22 years ago
Closed 22 years ago
DownloadListenerFactory::CreateInstance is missing some cases
Categories
(Camino Graveyard :: Downloading, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino0.9
People
(Reporter: darin.moz, Assigned: jaas)
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
mikepinkerton
:
review+
|
Details | Diff | Splinter Review |
DownloadListenerFactory::CreateInstance is missing some cases. We only create a
DownloadListener if asked for an object implementing nsIDownload, but the
DownloadListener class supports nsITransfer and nsISupports as well. Patch
coming up (though I can't seem to find where this code gets used.)
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
Reporter | |
Updated•22 years ago
|
Attachment #147935 -
Flags: review?(pinkerton)
|
|
Reporter | |
Comment 2•22 years ago
|
||
It looks like this code is duplicated in two places in the tree:
http://lxr.mozilla.org/mozilla/search?string=NewDownloadListenerFactory
I'm not sure which DownloadListenerFactory to modify... both? neither?
|
|
||
Comment 3•22 years ago
|
||
not critical for 0.8 i don't think, we can take this on the trunk only (right
darin?)
Assignee: pinkerton → josha
Target Milestone: --- → Camino0.9
|
|
Reporter | |
Comment 4•22 years ago
|
||
right, i don't know of anything that this breaks.
|
|
||
Comment 5•22 years ago
|
||
Comment on attachment 147935 [details] [diff] [review]
v1 patch
r=pink
Attachment #147935 -
Flags: review?(pinkerton) → review+
|
|
Reporter | |
Comment 6•22 years ago
|
||
fixed-on-trunk
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•