All users were logged out of Bugzilla on October 13th, 2018

nsHTTPHandler::GetMimeService unused

RESOLVED FIXED in mozilla1.8alpha1

Status

()

RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.8alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

nsHTTPHandler::GetMimeService is unused. this means that
nsHTTPHandler::mMimeService is also unused.
(REQUIERS=mimetype is still needed, for nsMimeTypes.h, used in nsHttpChannel,
for implementing nsIEncodedChannel)
Comment on attachment 147977 [details] [diff] [review]
patch

hm... I wonder why GetIOService doesn't just return an nsIIOService*...
Attachment #147977 - Flags: superreview?(darin)
Attachment #147977 - Flags: review?(darin)
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha

Comment 4

15 years ago
Comment on attachment 147977 [details] [diff] [review]
patch

r+sr=darin

Why is the bit in nsHttpTransaction.cpp needed?
Attachment #147977 - Flags: superreview?(darin)
Attachment #147977 - Flags: superreview+
Attachment #147977 - Flags: review?(darin)
Attachment #147977 - Flags: review+

Comment 5

15 years ago
As for GetIOService, I have plans to give Necko a global gIOService that can be
accessed directly from any code in the library.  There's too much of this
"isolationist" programming going on in Necko :-/
(In reply to comment #4)
> Why is the bit in nsHttpTransaction.cpp needed?

I'm not sure, but it is... I got an error about do_CreateInstance when I didn't
have that.

I suppose nsIMIMEService.h included a file that defined it, and none of the
other headers did..

(In reply to comment #5)
> As for GetIOService, I have plans to give Necko a global gIOService that can be
> accessed directly from any code in the library.  There's too much of this
> "isolationist" programming going on in Necko :-/

Ah, cool. Unfortunately nsNetUtil could not make use of this...
Checking in nsHttpHandler.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp,v  <-- 
nsHttpHandler.cpp
new revision: 1.100; previous revision: 1.99
done
Checking in nsHttpHandler.h;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.h,v  <--  nsHttpHandler.h
new revision: 1.41; previous revision: 1.40
done
Checking in nsHttpTransaction.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpTransaction.cpp,v  <-- 
nsHttpTransaction.cpp
new revision: 1.79; previous revision: 1.78
done
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.