Closed
Bug 243010
Opened 20 years ago
Closed 20 years ago
nsHTTPHandler::GetMimeService unused
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: Biesinger, Assigned: Biesinger)
References
()
Details
Attachments
(1 file)
3.50 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
nsHTTPHandler::GetMimeService is unused. this means that nsHTTPHandler::mMimeService is also unused.
Assignee | ||
Comment 1•20 years ago
|
||
(REQUIERS=mimetype is still needed, for nsMimeTypes.h, used in nsHttpChannel, for implementing nsIEncodedChannel)
Assignee | ||
Comment 2•20 years ago
|
||
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 147977 [details] [diff] [review] patch hm... I wonder why GetIOService doesn't just return an nsIIOService*...
Attachment #147977 -
Flags: superreview?(darin)
Attachment #147977 -
Flags: review?(darin)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha
Comment 4•20 years ago
|
||
Comment on attachment 147977 [details] [diff] [review] patch r+sr=darin Why is the bit in nsHttpTransaction.cpp needed?
Attachment #147977 -
Flags: superreview?(darin)
Attachment #147977 -
Flags: superreview+
Attachment #147977 -
Flags: review?(darin)
Attachment #147977 -
Flags: review+
Comment 5•20 years ago
|
||
As for GetIOService, I have plans to give Necko a global gIOService that can be accessed directly from any code in the library. There's too much of this "isolationist" programming going on in Necko :-/
Assignee | ||
Comment 6•20 years ago
|
||
(In reply to comment #4) > Why is the bit in nsHttpTransaction.cpp needed? I'm not sure, but it is... I got an error about do_CreateInstance when I didn't have that. I suppose nsIMIMEService.h included a file that defined it, and none of the other headers did.. (In reply to comment #5) > As for GetIOService, I have plans to give Necko a global gIOService that can be > accessed directly from any code in the library. There's too much of this > "isolationist" programming going on in Necko :-/ Ah, cool. Unfortunately nsNetUtil could not make use of this...
Assignee | ||
Comment 7•20 years ago
|
||
Checking in nsHttpHandler.cpp; /cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp,v <-- nsHttpHandler.cpp new revision: 1.100; previous revision: 1.99 done Checking in nsHttpHandler.h; /cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.h,v <-- nsHttpHandler.h new revision: 1.41; previous revision: 1.40 done Checking in nsHttpTransaction.cpp; /cvsroot/mozilla/netwerk/protocol/http/src/nsHttpTransaction.cpp,v <-- nsHttpTransaction.cpp new revision: 1.79; previous revision: 1.78 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•