243010 - nsHTTPHandler::GetMimeService unused

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsHTTPHandler::GetMimeService is unused. this means that
nsHTTPHandler::mMimeService is also unused.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

(REQUIERS=mimetype is still needed, for nsMimeTypes.h, used in nsHttpChannel,
for implementing nsIEncodedChannel)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 147977 [details] [diff] [review]
patch

hm... I wonder why GetIOService doesn't just return an nsIIOService*...

Comment 4

[Darin Fisher]

Comment on attachment 147977 [details] [diff] [review]
patch

r+sr=darin

Why is the bit in nsHttpTransaction.cpp needed?

Comment 5

[Darin Fisher]

As for GetIOService, I have plans to give Necko a global gIOService that can be
accessed directly from any code in the library.  There's too much of this
"isolationist" programming going on in Necko :-/

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #4)
> Why is the bit in nsHttpTransaction.cpp needed?

I'm not sure, but it is... I got an error about do_CreateInstance when I didn't
have that.

I suppose nsIMIMEService.h included a file that defined it, and none of the
other headers did..

(In reply to comment #5)
> As for GetIOService, I have plans to give Necko a global gIOService that can be
> accessed directly from any code in the library.  There's too much of this
> "isolationist" programming going on in Necko :-/

Ah, cool. Unfortunately nsNetUtil could not make use of this...

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsHttpHandler.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp,v  <-- 
nsHttpHandler.cpp
new revision: 1.100; previous revision: 1.99
done
Checking in nsHttpHandler.h;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.h,v  <--  nsHttpHandler.h
new revision: 1.41; previous revision: 1.40
done
Checking in nsHttpTransaction.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpTransaction.cpp,v  <-- 
nsHttpTransaction.cpp
new revision: 1.79; previous revision: 1.78
done