243118 - history.js references chrome://communicator/

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mike Connor [:mconnor]]

http://lxr.mozilla.org/mozilla/source/browser/components/history/content/history.js#121

introducted 12-30-2004 by ben's checkin for a security fix

Comment 1

[Simon Paquet [:sipaq]]

We could do a 

- var historyBundle =
strBundleService.createBundle("chrome://communicator/locale/history/history.properties");
+ var historyBundle =
strBundleService.createBundle("chrome://global/locale/history/history.properties");

as a quick fix.

But reading pch's last checkin comment for
mozilla/toolkit/components/history/locale/history.properties 

  1.3 <[e-mail]> 2003-11-03 00:14
  bug 221599: remove comm.jar dependencies in nsGlobalHistory.cpp by adding   
  history.properties for now. Putting the history in the toolkit seems highly 
  bogus."

I think we should think about a way of moving history.properties to
mozilla/browser where it belongs.

Mike, what do you think? I can supply the quick fix, but sorting out the right
solution for the underlying issue is far above my expertise.

Comment 2

[Mike Connor [:mconnor]]

yeah, quick fix is good for now.

Can you file a bug and cc me on moving nsGlobalHistory into /browser and out of
/toolkit?  That's future fodder for toolkit optimizations, which is my goal
post-1.0 (making the toolkit not suck)

Comment 3

[Simon Paquet [:sipaq]]

Attachment: quick fix for trunk

Comment 4

[Simon Paquet [:sipaq]]

I filed bug 251783 for the underlying issue.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 153438 [details] [diff] [review]
quick fix for trunk

fun

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 153438 [details] [diff] [review]
quick fix for trunk

a=[e-mail]

Comment 7

[Steffen Wilberg]

Checked into br & trunk 07/30/2004 06:24.