Closed Bug 243118 Opened 18 years ago Closed 17 years ago
.js references chrome://communicator/
http://lxr.mozilla.org/mozilla/source/browser/components/history/content/history.js#121 introducted 12-30-2004 by ben's checkin for a security fix
We could do a - var historyBundle = strBundleService.createBundle("chrome://communicator/locale/history/history.properties"); + var historyBundle = strBundleService.createBundle("chrome://global/locale/history/history.properties"); as a quick fix. But reading pch's last checkin comment for mozilla/toolkit/components/history/locale/history.properties 1.3 <email@example.com> 2003-11-03 00:14 bug 221599: remove comm.jar dependencies in nsGlobalHistory.cpp by adding history.properties for now. Putting the history in the toolkit seems highly bogus." I think we should think about a way of moving history.properties to mozilla/browser where it belongs. Mike, what do you think? I can supply the quick fix, but sorting out the right solution for the underlying issue is far above my expertise.
yeah, quick fix is good for now. Can you file a bug and cc me on moving nsGlobalHistory into /browser and out of /toolkit? That's future fodder for toolkit optimizations, which is my goal post-1.0 (making the toolkit not suck)
Assignee: bugs → bugzilla
Status: NEW → ASSIGNED
I filed bug 251783 for the underlying issue.
Comment on attachment 153438 [details] [diff] [review] quick fix for trunk fun
Attachment #153438 - Flags: review?(mconnor) → review+
Comment on attachment 153438 [details] [diff] [review] quick fix for trunk firstname.lastname@example.org
Attachment #153438 - Flags: approval-aviary? → approval-aviary+
Checked into br & trunk 07/30/2004 06:24.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: history depends on comm.jar → history.js references chrome://communicator/
Target Milestone: --- → Firefox1.0beta
Component: History → Bookmarks & History
QA Contact: mozilla → bookmarks
You need to log in before you can comment on or make changes to this bug.