problems with overlays and popups.

RESOLVED INVALID

Status

()

Core
XUL
P3
normal
RESOLVED INVALID
18 years ago
9 years ago

People

(Reporter: Scott MacGregor, Assigned: David Hyatt)

Tracking

Trunk
x86
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
I have a popup defined in messenger.xul that looks like:
<popupset>
  <popup id="emailAddressPopup"  popupanchor="bottomleft">
      <menuitem value="&AddToAddressBook.label;"
                oncommand="AddNodeToAddressBook(document.popupElement)"/>
      <menuseparator/>
      <menuitem value="&SendMailTo.label;"
                oncommand="SendMailToNode(document.popupElement)"/>
  </popup>
</popupset>

In the commercial build, I have an overlay which attempts to add a menu item to
this popup:

<popupset>
  <popup id="emailAddressPopup">
      <menuseparator/>
      <menuitem value="insert label"
                oncommand="foo();"/>
  </popup>
</popupset>

When I invoke the popup, I expected to see the menu item I added in the
commercial build inside the popup I defined in messenger.xul. i.e. the two
examples above should be merged into a single popup.

Instead, I only see the contents as defined in messenger.xul. My extra menu item
doesn't show up.
(Assignee)

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → INVALID
(Assignee)

Comment 1

18 years ago
This is bad XUL.  The <overlay> tag's immediate children are the ones that get
merged in.  You don't need a <popupset> over in the overlay.
(Reporter)

Comment 2

18 years ago
Thanks...removing the popupset fixed it!

Comment 3

18 years ago
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL

Comment 4

18 years ago
sorry fot the spam, changing QA contact.
QA Contact: paulmac → jrgm

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.