243176 - Manage Certificates and Manage Security Devices popup panels are too narrow (mostly with new profile)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Tim Meader]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040509 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040509 Firefox/0.8.0+

When you go to Options->Advanced->Certificates, and click on the button to
launch either the Manage Certificates or Manage Security Devices panels, both of
them launch with a width of around 50-75 pixels, and the window is not
resizeable, rendering them useless.

Reproducible: Always
Steps to Reproduce:
1.Go to Tools->Options->Advanced->Certificates
2.Click on either Manage Certificates or Manage Security Devices
3.Notice the narrow width.
4.Try to resize, you can't.

Actual Results:  
Panels are too narrow to be usable, and cannot be resized at all either.

Expected Results:  
They should be the original width that they used to be so that all content
inside the panel is usable and reachable.

Comment 1

[Andreas Kunz]

This is a Firefox prefs bug, not PSM.

"height=400" without width in
http://lxr.mozilla.org/seamonkey/source/browser/components/prefwindow/content/pref-advanced.js#149
is causing this, removing it makes everything work as expected.

http://lxr.mozilla.org/seamonkey/source/security/manager/pki/resources/content/certManager.xul#57
does already specify a size; if this size is not considered appropriate for
Firefox, width AND height have to be set it seems, like
http://lxr.mozilla.org/seamonkey/source/browser/components/prefwindow/content/pref-advanced.js#135
does.

BTW: panels CAN be resized and they even remember their size.

Comment 2

[Andreas Kunz]

Attachment: patch

This patch removes the height-specification so the default height (and width!!)
is used.

Comment 3

[Andreas Kunz]

Attachment: patch for MOZILLA_1_7_BRANCH

On the 1.7 branch the code resides in a different file, this patch does the
same as the other one.
I'm not sure about where this patch should go, so here you have both, do
whatever you want.

Comment 4

[Tim Meader]

Setting to major, since it makes a necessary feature completely unusable.

Comment 5

[Andreas Kunz]

Tim: this window is resizable (at least here, on XP, and as it is written in the
code). So how is it completely unusable?

Comment 6

[Tim Meader]

What version are you using?

Trunk nightly 20040518 Windows XP it is not resizeable... the window opens as
shown in the attachment I'm about to put in. It is NOT resizable, and thus
unusable. I will try the latest trunk when it comes out today. But unless the
patch in the bug has been checked in somehow, I don't see how it could have been
fixed.

Comment 7

[Mike Connor [:mconnor]]

this works for me here, is it broken in installer builds only?  the current code
makes this a resizeable window, even though it specifies a height.  The size is
also persisted properly.  Maybe you'd just seeing the other installer bustage?

Comment 8

[Tim Meader]

Just tested the 20040520 nightly... verified that it IS now resizeable, which is
a definite improvement. However, they still load up incredibly narrow, and I'm
not sure how many people are going to try to resize a dialog box... that's not
too intuitive. Hopefully the patch here can be looked at to correct the width
problem. I'm also assuming that this doesn't affect the AVIARY branch?

Resetting to normal.

Thanks.

Comment 9

[Andreas Kunz]

Mike Connor:
Did you really try creating a new profile?
I tried with a current cvs build when I did the patch and I just tried again
with what is called "latest-trunk" for Firefox on ftp.mozilla.org. Or aren't you
using Windows (XP)? Maybe there's a difference...

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 148556 [details] [diff] [review]
patch for MOZILLA_1_7_BRANCH

pref-advanced.js is on the branch now

I see this now, testing a couple things before I review

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 148554 [details] [diff] [review]
patch

I'm sure there's a bug behind this with specifying a height but not a width,
but this works in the meantime.

Comment 12

[Mike Connor [:mconnor]]

checked in aviary and trunk 2004-05-28 10:54

Comment 13

[Scott MacGregor]

Attachment: thunderbird version of the patch for the aviary branch

Comment 14

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change