Closed Bug 243214 Opened 20 years ago Closed 18 years ago

random cleanup in nsInternetSearchService

Categories

(SeaMonkey :: Search, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file, 1 obsolete file)

nsInternetSearchService has global comptrs that could be and should be member
vars (the rdf service and various rdf resources). I discovered this accidentally
while leaking domwindows.
Attachment #148127 - Flags: superreview?(bryner)
Attachment #148127 - Flags: review?(axel)
Comment on attachment 148127 [details] [diff] [review]
Make static comptrs into member vars.

I find it a bit inconsistent to rename some of the former globals to mFoo while
others remain kFoo.
Attachment #148127 - Flags: superreview?(bryner) → superreview+
Priority: -- → P4
Target Milestone: --- → mozilla1.9alpha
Pike, I'd like to clean this up, can you make a decision of some sort for me?
*** Bug 318929 has been marked as a duplicate of this bug. ***
Attached patch Updated to trunkSplinter Review
Axel, I'm happy to make the global kFoo -> mFoo change before checkin, but it would make this patch impossible to review. If I make that global change, I'll go ahead and fix all the indentation while I'm at it.
Attachment #148127 - Attachment is obsolete: true
Attachment #205377 - Flags: review?(axel)
Attachment #148127 - Flags: review?(axel)
Attachment #205377 - Flags: review?(axel) → review+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
Target Milestone: mozilla1.9alpha1 → seamonkey2.0a1
You need to log in before you can comment on or make changes to this bug.