Closed
Bug 243214
Opened 21 years ago
Closed 19 years ago
random cleanup in nsInternetSearchService
Categories
(SeaMonkey :: Search, defect, P4)
SeaMonkey
Search
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
78.15 KB,
patch
|
axel
:
review+
|
Details | Diff | Splinter Review |
nsInternetSearchService has global comptrs that could be and should be member
vars (the rdf service and various rdf resources). I discovered this accidentally
while leaking domwindows.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #148127 -
Flags: superreview?(bryner)
Attachment #148127 -
Flags: review?(axel)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 148127 [details] [diff] [review]
Make static comptrs into member vars.
I find it a bit inconsistent to rename some of the former globals to mFoo while
others remain kFoo.
|
||
Updated•21 years ago
|
Attachment #148127 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P4
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Comment 3•19 years ago
|
||
Pike, I'd like to clean this up, can you make a decision of some sort for me?
|
|
Assignee | |
Comment 4•19 years ago
|
||
*** Bug 318929 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 5•19 years ago
|
||
Axel, I'm happy to make the global kFoo -> mFoo change before checkin, but it would make this patch impossible to review. If I make that global change, I'll go ahead and fix all the indentation while I'm at it.
Attachment #148127 -
Attachment is obsolete: true
Attachment #205377 -
Flags: review?(axel)
Attachment #148127 -
Flags: review?(axel)
|
|
||
Updated•19 years ago
|
Attachment #205377 -
Flags: review?(axel) → review+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → SeaMonkey
|
||
Updated•16 years ago
|
Target Milestone: mozilla1.9alpha1 → seamonkey2.0a1
You need to log in
before you can comment on or make changes to this bug.
Description
•