nsInternetSearchService has global comptrs that could be and should be member vars (the rdf service and various rdf resources). I discovered this accidentally while leaking domwindows.
Comment on attachment 148127 [details] [diff] [review] Make static comptrs into member vars. I find it a bit inconsistent to rename some of the former globals to mFoo while others remain kFoo.
Attachment #148127 - Flags: superreview?(bryner) → superreview+
Priority: -- → P4
Target Milestone: --- → mozilla1.9alpha
Pike, I'd like to clean this up, can you make a decision of some sort for me?
*** Bug 318929 has been marked as a duplicate of this bug. ***
Created attachment 205377 [details] [diff] [review] Updated to trunk Axel, I'm happy to make the global kFoo -> mFoo change before checkin, but it would make this patch impossible to review. If I make that global change, I'll go ahead and fix all the indentation while I'm at it.
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.