243249 - "Number of Visits" doesn't update live in bookmark info Status tab

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Brion Vibber]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040510 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040510 Camino/0.7+

If I visit a bookmarked page while the Get Info palette is open for that
bookmark, the Visits Count in the Status tab does not increase until I go back
to the bookmark manager and either select another bookmark and go back to the
first one or close and reopen the palette.

Reproducible: Always
Steps to Reproduce:
1. Open bookmark manager
2. Get Info on a bookmark
3. Click Status tab
4. Double-click the bookmark to open the page in the browser
Actual Results:  
The Number of Visits does not visibly change in the still-open info palette.

Expected Results:  
The Number of Visits should visibly increment.

Mac OS 10.3.3

Comment 1

[Greg K.]

Confirmed using 2004050308 (v0.8b).

Comment 2

[David Haas (gone, not reading mail)]

Attachment: live updates

Does live updates of last visited time and number of visits.

Comment 3

[David Haas (gone, not reading mail)]

ping

Comment 4

[Josh Aas]

moving this bug up to 0.9 to get it on the radar since it has a patch

Comment 5

[Geoff "temporarily off bugmail" Beier]

Comment on attachment 158062 [details] [diff] [review]
live updates

Looks good and works as advertised. r=[e-mail]

Comment 6

[Mike Pinkerton (not reading bugmail)]

do we call |setBookmark:nil| before the window goes away, or unregister for the
notification? if not, we should.

Comment 7

[Geoff "temporarily off bugmail" Beier]

(In reply to comment #6)
> do we call |setBookmark:nil| before the window goes away, or unregister for the
> notification? if not, we should.

I think we do that here:
http://lxr.mozilla.org/mozilla/source/camino/src/bookmarks/BookmarkInfoController.mm#127

Comment 8

[Josh Aas]

Comment on attachment 158062 [details] [diff] [review]
live updates

sr=pinkerton given on IRC

Comment 9

[Josh Aas]

landed