243318 - Context.newArray does not allow derived array types

Status: RESOLVED WONTFIX

(Rhino Graveyard :: Core, enhancement)

Description

[Roland Knight]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: 

Context.newArray has an explicit check to prevent derived arrays from being 
passed. For example if you have a String[] you are forced to create an Object
[] and copy the contents of the String[] before you pass the array to newArray.

This can be fixed by removing the check in new Array as below:
    public final Scriptable newArray(Scriptable scope, Object[] elements)
    {
//        if (elements.getClass().getComponentType() != 
ScriptRuntime.ObjectClass)
//            throw new IllegalArgumentException();
        Scriptable result = new NativeArray(elements);
        newArrayHelper(scope, result);
        return result;
    }


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Igor Bukanov]

The check is done on purpose to prevent cast errors during assignments in JS.
Currently the array code in Rhino does not do any type checks when the array is
assigned and it may lead to hard to debug the errors. 

I would prefer for the check to exist until the array code is updated with
proper checks to throw proper JS exceptions. 

Comment 2

[Igor Bukanov]

There are too many corner cases to implemet this properly. Marking as WONTFIX.