243376 - Dragging local file onto tab gives error message and fails.

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[Simon Fraser [no longer active]]

Make a few tabs. Go to your ~/Sites folder, and try dragging the index.html onto
an existing tab. You'll get an error dialog saying "www.<.com could not be
found. Please check the name and try again". This is obviously bogus.

If you drag into the content area, it works fine.

Comment 1

[Simon Fraser [no longer active]]

It seems that on panther the string flavor in the drag is now an NSDictionary:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"
"http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<array>
	<string>/Users/smfr/Sites/index.html</string>
</array>
</plist>

Comment 2

[Simon Fraser [no longer active]]

Attachment: Fix: calll propertyListForType for filenames

This patch calls [NSPasteboard propertyListForType:] rather than
[stringForType:] to fix the issue. Multiple dragged files will be loaded in
several tabs, if the drop is over the tabs. Otherwise, just the first file will
be loaded in the content area.

Comment 3

[Simon Fraser [no longer active]]

This needs testing on 10.2.

Comment 4

[Mike Pinkerton (not reading bugmail)]

if it was just a string before, won't this new code flail on jaguar, or am i
missing something?

Comment 5

[Simon Fraser [no longer active]]

Dunno. That's why it needs testing  ;)

Comment 6

[Steve Ruge]

(In reply to comment #5)
> Dunno. That's why it needs testing  ;)

2004082512 (v0.8.1)/Mac OS 10.2.8: Works. I was able to drag the site from my
local Sites directory to an opened tab and the default MAC OS X PERSONAL WEB
SHARING page loaded successfully.

Comment 7

[ender.mb]

(In reply to comment #6)
> (In reply to comment #5)
> > Dunno. That's why it needs testing  ;)
> 
> 2004082512 (v0.8.1)/Mac OS 10.2.8: Works. I was able to drag the site from my
> local Sites directory to an opened tab and the default MAC OS X PERSONAL WEB
> SHARING page loaded successfully.

He meant that a build with the patch applied (i.e. a cvs checkout, not 0.8.1)
needs to be tested on 10.2.

Comment 8

[Wevah (Nate Weaver)]

The patch doesn't break anything under 10.2. However, I think that we should be
checking for NSFilenamesPboardType before NSURLPboardType (and maybe
NSStringPboardType), as (under 10.2 at least) NSURLPboardType seems to only send
a single URL, whereas NSFilenamesPboardType can have multiple filenames
associated with it. Because the ordering prefers NSURLPboardType (and possibly
with others) it only sees that one file:// URL and the new multiple-drop
behavior is never used (under 10.2).

Comment 9

[Josh Aas]

Attachment: try to get jaguar to handle multiple files

Takes into account Wevah's suggestions. Doesn't cause any problems on Panther,
hopefully helps things on Jaguar.

Comment 10

[Geoff "temporarily off bugmail" Beier]

(In reply to comment #9)
> Created an attachment (id=163270)
> try to get jaguar to handle multiple files

I just tested this patch on Jaguar. When I drop a single file onto a tab, it works as expected. When I drop 
multiple files, one of them is opened in the tab I drop it onto, and none of the others are opened.

Comment 11

[Josh Aas]

if we check in the patch "try to get jaguar to handle multiple files" we should
add a comment about the ordering of pasteboard type checking

Comment 12

[Wevah (Nate Weaver)]

(In reply to comment #10)
> (In reply to comment #9)
> > Created an attachment (id=163270)
> > try to get jaguar to handle multiple files
> 
> I just tested this patch on Jaguar. When I drop a single file onto a tab, it
works as expected. When I drop 
> multiple files, one of them is opened in the tab I drop it onto, and none of
the others are opened.

And it works great for me, while the other didn't. Go figure.

Comment 13

[Geoff "temporarily off bugmail" Beier]

After rebuilding and retesting this is working as described on 10.2 and does not
break anything on 10.3.

Comment 14

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 163270 [details] [diff] [review]
try to get jaguar to handle multiple files

sr=pink

i agree with josh, we should add a comment about the pasteboard ordering before
landing it.

Comment 15

[Josh Aas]

landed with comment added

Comment 16

[Hiro]

tinderbox is burning with this checkin.

Comment 17

[Josh Aas]

I fixed it almost as soon as it started burning - accidentally hit a key and
checked in the stray character.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think the fix for this bug caused the regression in bug 270123.  If not, sorry
for the noise.