Closed Bug 243418 Opened 21 years ago Closed 21 years ago

In <metadata.js>, "Warning: reference to undefined property tokens[0]"

Categories

(SeaMonkey :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8alpha1

People

(Reporter: sgautherie, Assigned: neil)

References

()

Details

Attachments

(1 file, 1 obsolete file)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040421] (<-- 1.7rc1 !)
(W98SE)

1. Load URL
2. Right Click on "Téléchargement sur-le-champ" button
3. > Properties

The dialog opens "fine", but generates a warning:
{{
Warning: reference to undefined property tokens[0]
Source File: chrome://navigator/content/metadata.js
Line: 568
}}
Attached patch (Av1_M) <metadata.js> (obsolete) — Splinter Review
Assignee: general → gautheri
Status: NEW → ASSIGNED
Comment on attachment 148314 [details] [diff] [review]
(Av1_M) <metadata.js>


This fixes the warning,
but I'm not sure if it's the proper fix or not...
Attachment #148314 - Flags: review?(neil.parkwaycc.co.uk)
Attached patch More cleanupSplinter Review
Assignee: gautheri → neil.parkwaycc.co.uk
Attachment #148314 - Attachment is obsolete: true
Attachment #148337 - Flags: review?(db48x)
Comment on attachment 148337 [details] [diff] [review]
More cleanup

What about Firefox? Their copy looks to have the same problem.
My understanding is that a separate bug has to be filed for the FireFox fix.
Comment on attachment 148337 [details] [diff] [review]
More cleanup

Ok. r=db48x
Attachment #148337 - Flags: review?(db48x) → review+
Attachment #148337 - Flags: superreview?(alecf)
Comment on attachment 148337 [details] [diff] [review]
More cleanup

sr=alecf
Attachment #148337 - Flags: superreview?(alecf) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Attachment #148314 - Flags: review?(neil.parkwaycc.co.uk)
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha
Comment on attachment 148337 [details] [diff] [review]
More cleanup

'approval1.7=?':
Trivial U.I. code cleanup, low risk.
Attachment #148337 - Flags: approval1.7?
Comment on attachment 148337 [details] [diff] [review]
More cleanup

warning cleanups can happen on the trunk. there's not much user value, even if
the risk is low -- and warning cleanups have broken features in the past.
Attachment #148337 - Flags: approval1.7? → approval1.7-
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: