243418 - In <metadata.js>, "Warning: reference to undefined property tokens[0]"

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040421] (<-- 1.7rc1 !)
(W98SE)

1. Load URL
2. Right Click on "Téléchargement sur-le-champ" button
3. > Properties

The dialog opens "fine", but generates a warning:
{{
Warning: reference to undefined property tokens[0]
Source File: chrome://navigator/content/metadata.js
Line: 568
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1_M) <metadata.js>

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 148314 [details] [diff] [review]
(Av1_M) <metadata.js>


This fixes the warning,
but I'm not sure if it's the proper fix or not...

Comment 3

[[e-mail]]

Attachment: More cleanup

Comment 4

[Daniel Brooks [:db48x]]

Comment on attachment 148337 [details] [diff] [review]
More cleanup

What about Firefox? Their copy looks to have the same problem.

Comment 5

[[e-mail]]

My understanding is that a separate bug has to be filed for the FireFox fix.

Comment 6

[Daniel Brooks [:db48x]]

Comment on attachment 148337 [details] [diff] [review]
More cleanup

Ok. r=db48x

Comment 7

[Alec Flett]

Comment on attachment 148337 [details] [diff] [review]
More cleanup

sr=alecf

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 148337 [details] [diff] [review]
More cleanup

'approval1.7=?':
Trivial U.I. code cleanup, low risk.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 148337 [details] [diff] [review]
More cleanup

warning cleanups can happen on the trunk. there's not much user value, even if
the risk is low -- and warning cleanups have broken features in the past.