24344 - No longer crashes (Crash when displaying a list box)

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Pierre Saslawsky]

On the Mac (I did not test with other platforms - I don't want to rebuild my tree
on Windows right now), it crashes whenever you display a list box, for instance:
- go to Test 8
- or go to Test 9
- or go to any bug page (eg. http://bugzilla.mozilla.org/show_bug.cgi?id=24343)
==> Crash

The culprit is nsListControlFrame.cpp line 1430, checked in by Rod this
afternoon. The line reads:
  nsCOMPtr<nsIContent> content(do_QueryInterface(content))

It crashes because the mRawPtr is null. Anyhow, the line looks wrong (we declare
and initialize the variable 'content' at the same time) and unnecessary
('content' is already declared above and it for sure contains an 'nsIContent'
already - we don't need to QueryInterface again). I'm going to comment out this
line even though the tree is closed.

I'm filing this bug just for the record and allow Rod to reopen it if necessary.

Comment 1

[rods (gone)]

reassigning to me

Comment 2

[rods (gone)]

Oops, accidently marked as fixed - reopening

Comment 3

[rods (gone)]

ok, reasigning to me again

Comment 4

[leger]

Clearing FIXED resolution due to reopen of this bug.

Comment 5

[rods (gone)]

changing to M14

Comment 6

[rods (gone)]

marking as assigned

Comment 7

[rods (gone)]

marking as assigned

Comment 8

[leger]

Adding "crash" keyword to all known open crasher bugs.

Comment 9

[rods (gone)]

fully fixed.

Comment 10

[Paul MacQuiddy]

please ignore, massive spam giving [e-mail] backlog of XPToolkits
resolved fixed bugs to verify