243452 - Pre-1.7b mozilla browsers hang if '//' is entered in the URL bar

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Darin Fisher]

Pre-1.7b mozilla browsers hang if '//' is entered in the URL bar.

The recent string branch landing (see bug 231995) that went in prior to 1.7b
fixed this bug.  The original bug report for the trunk was bug 185663, which is
currently resolved WORKSFORME (no apparent connection was made to bug 231995).

Folks making releases off the 1.6 branch or 1.4 branch may want this bug fixed
as well, but they certainly would not want to take the entire patch for bug 231995.
So, this bug is about making a focused patch for older branches.

Comment 1

[Darin Fisher]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Why not use nsAString::Insert?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 148345 [details] [diff] [review]
patch

(but if you don't want to do testing again, this does work, so r+sr=dbaron. 
Likewise for .Insert(NS_LITERAL_CSTRING("http://"), 0), etc.)

Comment 4

[Mary Hoetzel]

Attachment: Updated patch for Mozilla 1.4 branch

I added the original patch to a Mozilla 1.4 build and the line
   temp = NS_LITERAL_STRING("ftp://") + uriString;
fails to compile on AIX with the error message "The call does not match any
paramter list for operator+".

Changing the declaration for temp from nsCAutoString to nsAutoString fixes the
problem. That's because in the 1.4 version of the code, uriString is
nsAutoString and not nsCAutoString.

Comment 5

[Mike Kaply [:mkaply]]

Darin, please get this patch to the 1.4 branch and close out this bug.

Thanks

Comment 6

[timeless]

darin: you're the only person who understands this bug, please address the last comments :(

(yes, this goes against my own beliefs of being able to get rid of bugs that i don't care about, but, iirc your change was a mass change so, i'd be nice to get your view here.

note: if you tell me to stop touching your bugs, I'll gladly ignore all bugs you touch, i'm at a point where i'm likely to start ignoring all bugs anyway.)

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

I don't think anyone cares about 1.4 anymore, so I'll close this.